Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 9150011: Add some tests for dartdoc name reference resolution. (Closed)

Created:
8 years, 11 months ago by nweiz
Modified:
8 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add some tests for dartdoc name reference resolution. Currently these just test existing behavior, but the goal is to set the stage for adding more advanced resolution. TBR Committed: https://code.google.com/p/dart/source/detail?r=3117

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -9 lines) Patch
M utils/dartdoc/dartdoc.dart View 4 chunks +12 lines, -9 lines 1 comment Download
M utils/dartdoc/files.dart View 1 chunk +1 line, -0 lines 0 comments Download
M utils/dartdoc/test/dartdoc_tests.dart View 2 chunks +68 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
8 years, 11 months ago (2012-01-09 22:38:46 UTC) #1
Bob Nystrom
8 years, 11 months ago (2012-01-09 22:48:20 UTC) #2
One naming suggestion, otherwise LGTM.

http://codereview.chromium.org/9150011/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

http://codereview.chromium.org/9150011/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:785: md.Node resolveNameReference(String name,
[Member currentMember = null,
I wouldn't use "current", just "member", "type" and "library".

Powered by Google App Engine
This is Rietveld 408576698