Issue 9148062: Let test.dart's compact progress indicator be overwritten by the summary report.

Issue 9148062: Let test.dart's compact progress indicator be overwritten by the summary report. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
ricow1, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Let test.dart's compact progress indicator be overwritten by the summary report. BUG=dart:1125 TEST=tools/test.dart --report Committed: https://code.google.com/p/dart/source/detail?r=3238

Patch Set 1 #

Total comments: 4

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	tools/testing/dart/test_progress.dart	View		1 chunk	+10 lines, -0 lines	2 comments	Download
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+3 lines, -4 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

http://codereview.chromium.org/9148062/diff/1/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): http://codereview.chromium.org/9148062/diff/1/tools/testing/dart/test_progress.dart#newcode170 tools/testing/dart/test_progress.dart:170: void allTestsKnown() { Put a comment that this is ...

8 years, 11 months ago (2012-01-12 12:53:35 UTC) #1

Anders Johnsen

LGTM, with one comment. http://codereview.chromium.org/9148062/diff/1/tools/testing/dart/test_progress.dart File tools/testing/dart/test_progress.dart (right): http://codereview.chromium.org/9148062/diff/1/tools/testing/dart/test_progress.dart#newcode174 tools/testing/dart/test_progress.dart:174: '\r \r'.charCodes()); Are we sure ...

8 years, 11 months ago (2012-01-12 14:25:25 UTC) #3

Bill Hesse

8 years, 11 months ago (2012-01-12 14:47:25 UTC) #4

On 2012/01/12 14:25:25, ajohnsen wrote:
> LGTM, with one comment.
> 
>
http://codereview.chromium.org/9148062/diff/1/tools/testing/dart/test_progres...
> File tools/testing/dart/test_progress.dart (right):
> 
>
http://codereview.chromium.org/9148062/diff/1/tools/testing/dart/test_progres...
> tools/testing/dart/test_progress.dart:174: '\r                                
 
>             \r'.charCodes());
> Are we sure this number of spaces are sufficient?

I'm sure.  The progress indicator uses fixed numeric size fields, and is small.

Expand Messages | Collapse Messages