Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 9146019: Make test.dart not barf if the path to your repo has 'src/' in it. (Closed)

Created:
8 years, 11 months ago by Bob Nystrom
Modified:
8 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make test.dart not barf if the path to your repo has 'src/' in it. Committed: https://code.google.com/p/dart/source/detail?r=3125

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M tools/testing/dart/test_suite.dart View 13 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bob Nystrom
I have my dart repo in a "src" directory. After much tracking down, I figured ...
8 years, 11 months ago (2012-01-10 00:31:31 UTC) #1
Emily Fortuna
lgtm!
8 years, 11 months ago (2012-01-10 00:41:15 UTC) #2
Jennifer Messerly
On 2012/01/10 00:41:15, Emily Fortuna wrote: > lgtm! Now you just have to make sure ...
8 years, 11 months ago (2012-01-10 04:17:07 UTC) #3
Mads Ager (google)
8 years, 11 months ago (2012-01-10 07:50:09 UTC) #4
Thanks for creating this quick fix Bob!

The problem here is that we don't get the script argument into dart as part of
the Options. We therefore have no good way of determining what the dart root
directory is. It is easy to make the script name available as part of the
Options interface and avoid all this hacking when it comes to determining the
relative path of the tests.

Powered by Google App Engine
This is Rietveld 408576698