continued cleanup of initialization and Value

continued cleanup of initialization and Value

Less code, more tests passing...  EvaluatedValue and MethodGenerator.evalBody are both in the right direction but will be evolving fairly rapidly to get to a fully cleaned up state.

Committed: https://code.google.com/p/dart/source/detail?r=3077

[jimhug, 2012-01-09 03:41:01]

tbr

This is probably the first of the weekend's reviews worth taking a close look
at.  I'm looking forward to discussing the direction towards abstract
interpretation this is taking.  So far, I found its been a bit of a refactoring
challenge - but it has really been nice for unifying and modularizing a lot of
"const" and general initialization code paths.

[Jennifer Messerly, 2012-01-09 20:45:34]

lgtm!

http://codereview.chromium.org/9146001/diff/2001/frog/gen.dart
File frog/gen.dart (right):

http://codereview.chromium.org/9146001/diff/2001/frog/gen.dart#newcode1128
frog/gen.dart:1128: newObject.dynamic.seenNativeInitializer = true;
I see you've embraced the Dart "cast" syntax ;)

http://codereview.chromium.org/9146001/diff/2001/frog/gen.dart#newcode1135
frog/gen.dart:1135: // TODO(jimhug): bareCount is O(N)
It gets cached though. So it's amortized O(1)

http://codereview.chromium.org/9146001/diff/2001/frog/gen.dart#newcode2203
frog/gen.dart:2203: return value.unop(node.op.kind, this, node);
so nice

http://codereview.chromium.org/9146001/diff/2001/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/9146001/diff/2001/frog/member.dart#newcode1071
frog/member.dart:1071: // ??? Does args.values include named args???
add a TODO here?

[jimhug, 2012-01-09 21:12:17]

Thanks for the comments - I'm preparing a followup CL with responses to all
three of your reviews.

http://codereview.chromium.org/9146001/diff/2001/frog/gen.dart
File frog/gen.dart (right):

http://codereview.chromium.org/9146001/diff/2001/frog/gen.dart#newcode1135
frog/gen.dart:1135: // TODO(jimhug): bareCount is O(N)
On 2012/01/09 20:45:35, John Messerly wrote:
> It gets cached though. So it's amortized O(1)
I'd missed that!  Thanks, I'll remove the comment.

http://codereview.chromium.org/9146001/diff/2001/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/9146001/diff/2001/frog/member.dart#newcode1071
frog/member.dart:1071: // ??? Does args.values include named args???
On 2012/01/09 20:45:35, John Messerly wrote:
> add a TODO here?

I've figured out the answer - so I'll remove the comment entirely.  The answer
is as expected and it does include named args.