Issue 9139080: Rename the VM internal class ByteArray to ByteVector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9139080: Rename the VM internal class ByteArray to ByteVector. (Closed)

Created:
8 years, 11 months ago by cshapiro

Modified:
8 years, 11 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename the VM internal class ByteArray to ByteVector. Committed: https://code.google.com/p/dart/source/detail?r=3274

Patch Set 2 : new strategy #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -81 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/debuginfo.h	View	1	3 chunks	+50 lines, -51 lines	0 comments	Download
M	runtime/vm/debuginfo_linux.cc	View	1	13 chunks	+37 lines, -27 lines	0 comments	Download
M	runtime/vm/debuginfo_macos.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/debuginfo_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

http://codereview.chromium.org/9139080/diff/1/runtime/vm/debuginfo.h File runtime/vm/debuginfo.h (right): http://codereview.chromium.org/9139080/diff/1/runtime/vm/debuginfo.h#newcode15 runtime/vm/debuginfo.h:15: class ByteVector { DebugInfo::ByteBuffer => no more conflicts...

8 years, 11 months ago (2012-01-13 00:32:44 UTC) #2

LGTM -ip

Expand Messages | Collapse Messages

Issue 9139080: Rename the VM internal class ByteArray to ByteVector. (Closed)

Description

Patch Set 1 #

Patch Set 2 : new strategy #

Messages