Make browser "sometest" like a regular test run by test.dart/py instead of

Make browser "sometest" like a regular test run by test.dart/py instead of
create_graph.py
Committed: https://code.google.com/p/dart/source/detail?r=3213

[Siggi Cherem (dart-lang), 2012-01-11 21:57:31]

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
File client/tests/client/samples/smoketest/BenchmarkBase.dart (right):

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
client/tests/client/samples/smoketest/BenchmarkBase.dart:5: /** Accessors for
our Singleton variables. */
I assume this file is unchanged? (just a move from a diff dir?)

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
File client/tests/client/samples/smoketest/dartWebBase_tests.dart (right):

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
client/tests/client/samples/smoketest/dartWebBase_tests.dart:11:
window.setTimeout(() => BENCHMARK_SUITE.runBenchmarks(), 200);
do you need real time here? or can you simply do setTimeout(., 0) 
(same bellow)

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
client/tests/client/samples/smoketest/dartWebBase_tests.dart:12: // Aribtrary
timeout number. This can be adjusted or made part of the options.
80

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
client/tests/client/samples/smoketest/dartWebBase_tests.dart:13:
window.setTimeout(() => testForCompletion(), 2000);
you should be able to pass here testForCompletion directly:
window.setTimeout(testForCompletion, 2000)

[Emily Fortuna, 2012-01-11 22:15:11]

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
File client/tests/client/samples/smoketest/BenchmarkBase.dart (right):

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
client/tests/client/samples/smoketest/BenchmarkBase.dart:5: /** Accessors for
our Singleton variables. */
The only code that changed was from dartWebBase.dart --> dartWebBase_tests.dart
and some of the code inside that file (which you already looked at), and one
spot in this file -- I'll add a note so you can see the difference.

On 2012/01/11 21:57:31, sigmund wrote:
> I assume this file is unchanged? (just a move from a diff dir?)

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
client/tests/client/samples/smoketest/BenchmarkBase.dart:170: body.nodes.add(new
Element.html("<p id='testResultScore'>Score: $newScore</p>"));
We add a new "p" element to hold the "score" result, since previously I was
relying on the format of the html page that I had build by hand with a specific
div element name.

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
File client/tests/client/samples/smoketest/dartWebBase_tests.dart (right):

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
client/tests/client/samples/smoketest/dartWebBase_tests.dart:11:
window.setTimeout(() => BENCHMARK_SUITE.runBenchmarks(), 200);
On 2012/01/11 21:57:31, sigmund wrote:
> do you need real time here? or can you simply do setTimeout(., 0) 
> (same bellow)

Done.

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
client/tests/client/samples/smoketest/dartWebBase_tests.dart:12: // Aribtrary
timeout number. This can be adjusted or made part of the options.
On 2012/01/11 21:57:31, sigmund wrote:
> 80

Done.

http://codereview.chromium.org/9139031/diff/2001/client/tests/client/samples/...
client/tests/client/samples/smoketest/dartWebBase_tests.dart:13:
window.setTimeout(() => testForCompletion(), 2000);
On 2012/01/11 21:57:31, sigmund wrote:
> you should be able to pass here testForCompletion directly:
> window.setTimeout(testForCompletion, 2000)

Done.

http://codereview.chromium.org/9139031/diff/2001/tools/testing/perf_testing/s...
File tools/testing/perf_testing/smoketest/BenchmarkBase.dart (left):

http://codereview.chromium.org/9139031/diff/2001/tools/testing/perf_testing/s...
tools/testing/perf_testing/smoketest/BenchmarkBase.dart:171: status.innerHTML = 
"Score: $newScore <br>";
This is changed. (see line 170 in the new version of this file.)

[Siggi Cherem (dart-lang), 2012-01-11 22:23:20]

lgtm

http://codereview.chromium.org/9139031/diff/14/client/tests/client/samples/sm...
File client/tests/client/samples/smoketest/BenchmarkBase.dart (right):

http://codereview.chromium.org/9139031/diff/14/client/tests/client/samples/sm...
client/tests/client/samples/smoketest/BenchmarkBase.dart:170: body.nodes.add(new
Element.html("<p id='testResultScore'>Score: $newScore</p>"));
80 col :)