Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 9139020: closing out Library*NegativeTest issue and adding comments (Closed)

Created:
8 years, 11 months ago by jimhug
Modified:
8 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updates language.status to reflect the invalid status of issue #354. Also adds comments to the test cases to help clarify their intended behavior for future readers. Committed: https://code.google.com/p/dart/source/detail?r=3202

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -23 lines) Patch
M tests/language/language.status View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/language/src/Library1NegativeTest.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/language/src/Library4NegativeTest.dart View 1 chunk +6 lines, -7 lines 0 comments Download
M tests/language/src/Library5NegativeTest.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M tests/language/src/Library6NegativeTest.dart View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jimhug
Hi Siva, I'm trying to ensure a clean resolution to the library negative tests confusions ...
8 years, 11 months ago (2012-01-11 18:42:05 UTC) #1
siva
8 years, 11 months ago (2012-01-11 19:23:57 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698