Issue 9139017: Make test_wrapper.py and test_compiler.dart that will work for a deps.compiler checkout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9139017: Make test_wrapper.py and test_compiler.dart that will work for a deps.compiler checkout. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make test_wrapper.py and test_compiler.dart that will work for a deps.compiler checkout. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3236

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change name to test-compiler.dart, add comments. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -7 lines)			Patch
A +	tools/test-compiler.dart	View	1	4 chunks	+16 lines, -5 lines	0 comments	Download
M	tools/test-runtime.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/test_wrapper.py	View	1	1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

8 years, 11 months ago (2012-01-12 13:54:26 UTC) #3

lgtm

http://codereview.chromium.org/9139017/diff/1/tools/test_compiler.dart
File tools/test_compiler.dart (right):

http://codereview.chromium.org/9139017/diff/1/tools/test_compiler.dart#newcode5
tools/test_compiler.dart:5: 
I think we should have a comment here (and in all toplevel test scripts)
explaining something about how they relate.

http://codereview.chromium.org/9139017/diff/1/tools/test_wrapper.py
File tools/test_wrapper.py (right):

http://codereview.chromium.org/9139017/diff/1/tools/test_wrapper.py#newcode27
tools/test_wrapper.py:27: dart_script_name = 'test_compiler.dart'
test-runtime.dart is with a dash and test_compiler.dart is with an underscore.
Please use one or the other.

Expand Messages | Collapse Messages