Issue 9139014: Allow for-in to use a previously declared identifier as variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9139014: Allow for-in to use a previously declared identifier as variable. (Closed)

Created:
8 years, 11 months ago by Lasse Reichstein

Modified:
8 years, 11 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow for-in to use a previously declared identifier as variable. Committed: https://code.google.com/p/dart/source/detail?r=3229

Patch Set 2 : Add more tests #

Total comments: 3

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -10 lines)			Patch
M	frog/leg/resolver.dart	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	frog/leg/ssa/builder.dart	View		1 chunk	+8 lines, -3 lines	3 comments	Download
M	frog/leg/warnings.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	frog/tests/leg_only/src/ForInTest.dart	View	1	2 chunks	+38 lines, -0 lines	0 comments	Download
M	tests/language/language-leg.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! http://codereview.chromium.org/9139014/diff/2001/frog/leg/ssa/builder.dart File frog/leg/ssa/builder.dart (right): http://codereview.chromium.org/9139014/diff/2001/frog/leg/ssa/builder.dart#newcode1333 frog/leg/ssa/builder.dart:1333: if (node.declaredIdentifier is Send) { is Send -> ...

8 years, 11 months ago (2012-01-11 15:20:09 UTC) #2

Lasse Reichstein

8 years, 11 months ago (2012-01-12 07:49:30 UTC) #3

http://codereview.chromium.org/9139014/diff/2001/frog/leg/ssa/builder.dart
File frog/leg/ssa/builder.dart (right):

http://codereview.chromium.org/9139014/diff/2001/frog/leg/ssa/builder.dart#ne...
frog/leg/ssa/builder.dart:1337: variable =
elements[node.declaredIdentifier.definitions.nodes.head];
Ah ok. Where do I disable warnings :P.

Expand Messages | Collapse Messages

Issue 9139014: Allow for-in to use a previously declared identifier as variable. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add more tests #

Messages