Issue 9139012: Fix flaky error on buildbot due to virtual X server xvfb.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9139012: Fix flaky error on buildbot due to virtual X server xvfb. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix flaky error on buildbot due to virtual X server xvfb. The test.py test script handles this flaky error, and this CL adds handling of this error to the test.dart script. Issue dart:1135 is filed to get rid of this error. BUG=dart:1135 TEST=xvfb-run tools/test.py -cchromium language Committed: https://code.google.com/p/dart/source/detail?r=3182

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

8 years, 11 months ago (2012-01-11 17:43:08 UTC) #3

The test was in the wrong place, so the flaky tests still report failure.  Also,
tests that expect to fail will not handle success well.

Expand Messages | Collapse Messages