Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 9139011: Handle EINTR on all IO operations (Closed)

Created:
8 years, 11 months ago by Søren Gjesse
Modified:
8 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle EINTR on all IO operations There have been spurious FileIOExceptions seen on some Mac OS machines. R=ager@google.com,whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3185

Patch Set 1 #

Patch Set 2 : Fixed building on Mac OS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -308 lines) Patch
M runtime/bin/directory_posix.cc View 9 chunks +20 lines, -9 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 6 chunks +16 lines, -12 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 7 chunks +17 lines, -13 lines 0 comments Download
M runtime/bin/fdutils_linux.cc View 6 chunks +22 lines, -21 lines 0 comments Download
M runtime/bin/fdutils_macos.cc View 6 chunks +22 lines, -21 lines 0 comments Download
M runtime/bin/file_linux.cc View 8 chunks +18 lines, -16 lines 0 comments Download
M runtime/bin/file_macos.cc View 9 chunks +24 lines, -22 lines 0 comments Download
M runtime/bin/process_linux.cc View 12 chunks +74 lines, -70 lines 0 comments Download
M runtime/bin/process_macos.cc View 12 chunks +74 lines, -70 lines 0 comments Download
M runtime/bin/socket_linux.cc View 9 chunks +33 lines, -27 lines 0 comments Download
M runtime/bin/socket_macos.cc View 9 chunks +33 lines, -27 lines 0 comments Download
M runtime/platform/globals.h View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 11 months ago (2012-01-11 13:18:17 UTC) #1
Bill Hesse
8 years, 11 months ago (2012-01-11 14:12:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698