Frog DOM changes to support OLS on Storage objects

Frog DOM changes to support OLS on Storage objects

Committed: https://code.google.com/p/dart/source/detail?r=3204

[vsm, 2012-01-09 22:03:25]

Script implementation add.

PTAL

[vsm, 2012-01-09 22:04:21]

Corresponding test here:

http://codereview.chromium.org/9147009/

[sra1, 2012-01-09 22:20:01]

http://codereview.chromium.org/9138007/diff/1/client/dom/frog/dom_frog.dart
File client/dom/frog/dom_frog.dart (right):

http://codereview.chromium.org/9138007/diff/1/client/dom/frog/dom_frog.dart#n...
client/dom/frog/dom_frog.dart:9131: """;
The native method needs a Dart body that references the exception, otherwise the
compiler won't generate it:

var get foo() native """
  ...
  \$throw(new XXX('abc'));
  ...
""" {
   new XXX('');
}

http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
File client/dom/scripts/dartgenerator.py (right):

http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:144: # expando.  Instead, we define a
specialized getter and setter.
Do you think this approach will work if we make all dom impl types extend
DOMType and have the method on DOMType?

DOMType.dartObjectLocalStorage would be the expando, and it would be overridded
by Storage.dartObjectLocalStorage.

http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:1896: if interface_name in
_unexpandable_types.keys():
I believe 'in' just works on the keys of a dict()

[sra1, 2012-01-09 22:21:02]

On 2012/01/09 22:20:01, sra1 wrote:
> http://codereview.chromium.org/9138007/diff/1/client/dom/frog/dom_frog.dart
> File client/dom/frog/dom_frog.dart (right):
> 
>
http://codereview.chromium.org/9138007/diff/1/client/dom/frog/dom_frog.dart#n...
> client/dom/frog/dom_frog.dart:9131: """;
> The native method needs a Dart body that references the exception, otherwise
the
> compiler won't generate it:
> 
> var get foo() native """
>   ...
>   \$throw(new XXX('abc'));
>   ...
> """ {
>    new XXX('');
> }
> 

See frog/lib/math.dart: parseDouble for example.

>
http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
> File client/dom/scripts/dartgenerator.py (right):
> 
>
http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
> client/dom/scripts/dartgenerator.py:144: # expando.  Instead, we define a
> specialized getter and setter.
> Do you think this approach will work if we make all dom impl types extend
> DOMType and have the method on DOMType?
> 
> DOMType.dartObjectLocalStorage would be the expando, and it would be
overridded
> by Storage.dartObjectLocalStorage.
> 
>
http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
> client/dom/scripts/dartgenerator.py:1896: if interface_name in
> _unexpandable_types.keys():
> I believe 'in' just works on the keys of a dict()

[vsm, 2012-01-10 00:42:00]

http://codereview.chromium.org/9138007/diff/1/client/dom/frog/dom_frog.dart
File client/dom/frog/dom_frog.dart (right):

http://codereview.chromium.org/9138007/diff/1/client/dom/frog/dom_frog.dart#n...
client/dom/frog/dom_frog.dart:9131: """;
On 2012/01/09 22:20:06, sra1 wrote:
> The native method needs a Dart body that references the exception, otherwise
the
> compiler won't generate it:
> 
> var get foo() native """
>   ...
>   \$throw(new XXX('abc'));
>   ...
> """ {
>    new XXX('');
> }

Done.

http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
File client/dom/scripts/dartgenerator.py (right):

http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:144: # expando.  Instead, we define a
specialized getter and setter.
It feels like it should.  It's legal dart to override a field with a getter /
setter.  And, as the compiler is patching the Storage proto with the getter and
setter, it may already do the right thing.

On 2012/01/09 22:20:06, sra1 wrote:
> Do you think this approach will work if we make all dom impl types extend
> DOMType and have the method on DOMType?
> 
> DOMType.dartObjectLocalStorage would be the expando, and it would be
overridded
> by Storage.dartObjectLocalStorage.

http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
client/dom/scripts/dartgenerator.py:1896: if interface_name in
_unexpandable_types.keys():
On 2012/01/09 22:20:06, sra1 wrote:
> I believe 'in' just works on the keys of a dict()

Done.

[vsm, 2012-01-10 23:47:06]

PTAL when you get chance.

On 2012/01/10 00:42:00, vsm wrote:
> http://codereview.chromium.org/9138007/diff/1/client/dom/frog/dom_frog.dart
> File client/dom/frog/dom_frog.dart (right):
> 
>
http://codereview.chromium.org/9138007/diff/1/client/dom/frog/dom_frog.dart#n...
> client/dom/frog/dom_frog.dart:9131: """;
> On 2012/01/09 22:20:06, sra1 wrote:
> > The native method needs a Dart body that references the exception, otherwise
> the
> > compiler won't generate it:
> > 
> > var get foo() native """
> >   ...
> >   \$throw(new XXX('abc'));
> >   ...
> > """ {
> >    new XXX('');
> > }
> 
> Done.
> 
>
http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
> File client/dom/scripts/dartgenerator.py (right):
> 
>
http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
> client/dom/scripts/dartgenerator.py:144: # expando.  Instead, we define a
> specialized getter and setter.
> It feels like it should.  It's legal dart to override a field with a getter /
> setter.  And, as the compiler is patching the Storage proto with the getter
and
> setter, it may already do the right thing.
> 
> On 2012/01/09 22:20:06, sra1 wrote:
> > Do you think this approach will work if we make all dom impl types extend
> > DOMType and have the method on DOMType?
> > 
> > DOMType.dartObjectLocalStorage would be the expando, and it would be
> overridded
> > by Storage.dartObjectLocalStorage.
> 
>
http://codereview.chromium.org/9138007/diff/1/client/dom/scripts/dartgenerato...
> client/dom/scripts/dartgenerator.py:1896: if interface_name in
> _unexpandable_types.keys():
> On 2012/01/09 22:20:06, sra1 wrote:
> > I believe 'in' just works on the keys of a dict()
> 
> Done.

[vsm, 2012-01-11 01:05:26]

Some more cleanup as discussed.  PTAL.

[sra1, 2012-01-11 02:25:04]

lgtm