Issue 9128002: Print stop message.

Issue 9128002: Print stop message. (Closed)

Created:
8 years, 11 months ago by regis

Modified:
8 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Print stop message. Committed: https://code.google.com/p/dart/source/detail?r=3124

Patch Set 3 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -15 lines)			Patch
M	runtime/vm/assembler_ia32.cc	View	1 2	2 chunks	+15 lines, -5 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 2	2 chunks	+19 lines, -6 lines	0 comments	Download
M	runtime/vm/stub_code.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2	1 chunk	+40 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2	2 chunks	+50 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

http://codereview.chromium.org/9128002/diff/1/runtime/vm/assembler_ia32.cc File runtime/vm/assembler_ia32.cc (right): http://codereview.chromium.org/9128002/diff/1/runtime/vm/assembler_ia32.cc#newcode1448 runtime/vm/assembler_ia32.cc:1448: popl(EAX); This destroys whatever was in EAX. http://codereview.chromium.org/9128002/diff/1/runtime/vm/assembler_x64.cc File ...

8 years, 11 months ago (2012-01-09 17:26:42 UTC) #2

regis

Thanks. Please have another look. -- Regis http://codereview.chromium.org/9128002/diff/1/runtime/vm/assembler_ia32.cc File runtime/vm/assembler_ia32.cc (right): http://codereview.chromium.org/9128002/diff/1/runtime/vm/assembler_ia32.cc#newcode1448 runtime/vm/assembler_ia32.cc:1448: popl(EAX); On ...

8 years, 11 months ago (2012-01-10 00:09:16 UTC) #3

Ivan Posva

LGTM with comment. -Ivan http://codereview.chromium.org/9128002/diff/8001/runtime/vm/assembler_ia32.cc File runtime/vm/assembler_ia32.cc (right): http://codereview.chromium.org/9128002/diff/8001/runtime/vm/assembler_ia32.cc#newcode1450 runtime/vm/assembler_ia32.cc:1450: } See comment in x64 ...

8 years, 11 months ago (2012-01-10 00:18:17 UTC) #4

regis

8 years, 11 months ago (2012-01-10 00:32:37 UTC) #5

Thanks!

http://codereview.chromium.org/9128002/diff/8001/runtime/vm/assembler_ia32.cc
File runtime/vm/assembler_ia32.cc (right):

http://codereview.chromium.org/9128002/diff/8001/runtime/vm/assembler_ia32.cc...
runtime/vm/assembler_ia32.cc:1450: }
On 2012/01/10 00:18:17, Ivan Posva wrote:
> See comment in x64 code about the testl.

Done.

http://codereview.chromium.org/9128002/diff/8001/runtime/vm/assembler_x64.cc
File runtime/vm/assembler_x64.cc (right):

http://codereview.chromium.org/9128002/diff/8001/runtime/vm/assembler_x64.cc#...
runtime/vm/assembler_x64.cc:1321: testl(RAX,
Immediate(Utils::Low32Bits(message_address)));
On 2012/01/10 00:18:17, Ivan Posva wrote:
> How about wrapping the testl instructions into the else of the "if
> (FLAG_print_stop_message)"?

Done.

http://codereview.chromium.org/9128002/diff/8001/runtime/vm/stub_code_ia32.cc
File runtime/vm/stub_code_ia32.cc (right):

http://codereview.chromium.org/9128002/diff/8001/runtime/vm/stub_code_ia32.cc...
runtime/vm/stub_code_ia32.cc:137: __ pushl(EAX);
On 2012/01/10 00:18:17, Ivan Posva wrote:
> Destroys stack alignment.

Good catch. Fixed.

Expand Messages | Collapse Messages