Issue 9126001: Fix Leg test failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9126001: Fix Leg test failures. (Closed)

Created:
8 years, 11 months ago by Lasse Reichstein

Modified:
8 years, 11 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Leg test failures. Change expectation for test that now succeedes. Add conservative equality for QuotedString, and stop assuming string HLiterals can compare their .values directly. Committed: https://code.google.com/p/dart/source/detail?r=3025

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove accidental edit. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
M	frog/leg/ssa/nodes.dart	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	frog/leg/ssa/optimize.dart	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	tests/language/language-leg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. http://codereview.chromium.org/9126001/diff/1/frog/leg/ssa/optimize.dart File frog/leg/ssa/optimize.dart (right): http://codereview.chromium.org/9126001/diff/1/frog/leg/ssa/optimize.dart#newcode92 frog/leg/ssa/optimize.dart:92: if (node.left.isString() && node.right is HLiteral) { Remove ...

8 years, 11 months ago (2012-01-06 09:58:38 UTC) #2

Lasse Reichstein

8 years, 11 months ago (2012-01-06 10:01:07 UTC) #3

http://codereview.chromium.org/9126001/diff/1/frog/leg/ssa/optimize.dart
File frog/leg/ssa/optimize.dart (right):

http://codereview.chromium.org/9126001/diff/1/frog/leg/ssa/optimize.dart#newc...
frog/leg/ssa/optimize.dart:92: if (node.left.isString() && node.right is
HLiteral) {
On 2012/01/06 09:58:38, karlklose wrote:
> Remove accidental edit.

Done.

Expand Messages | Collapse Messages