Issue 9125011: Fix for Issue 1075

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9125011: Fix for Issue 1075 (Closed)

Created:
8 years, 11 months ago by sra1

Modified:
8 years, 11 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for Issue 1075 Don't use ImplementationFunction - that is the C++ name. There used to be a problem with IDBCursor.delete - some browsers didn't like the call foo.delete() The way to fix this if it reappears is to generate foo['delete']() instead. BUG=1075 TEST= Committed: https://code.google.com/p/dart/source/detail?r=3060

Patch Set 1 #

Patch Set 2 : merge #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -22 lines)			Patch
M	client/dom/frog/dom_frog.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	client/dom/generated/src/frog/Console.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/dom/generated/src/interface/Console.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	client/dom/generated/src/wrapping/_ConsoleWrappingImplementation.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	client/dom/generated/wrapping_dom.js	View		7 chunks	+8 lines, -8 lines	0 comments	Download
M	client/dom/generated/wrapping_dom_externs.js	View		6 chunks	+5 lines, -6 lines	0 comments	Download
M	client/dom/idl/dart/dart.idl	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	client/dom/scripts/dartgenerator.py	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages