Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 9124030: Cleanup gypi mess. (Closed)

Created:
8 years, 11 months ago by Mads Ager (google)
Modified:
8 years, 11 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Cleanup gypi mess. My change that introduced a platform directory shared between vm and bin runtime components did not correctly update gypi files. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3155

Patch Set 1 #

Total comments: 33

Patch Set 2 : Update copyrights #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M runtime/bin/bin.gypi View 1 4 chunks +4 lines, -1 line 0 comments Download
M runtime/bin/builtin.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/dartutils.h View 1 2 chunks +1 line, -3 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/directory.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/fdutils.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/file_test.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/main.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/process.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/process_win.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/socket.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/thread_pool.h View 1 chunk +0 lines, -1 line 0 comments Download
A runtime/platform/platform_sources.gypi View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/vm.gypi View 1 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/vm_sources.gypi View 1 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
8 years, 11 months ago (2012-01-07 08:24:52 UTC) #1
Ivan Posva
Contents looks good, dates don't. -Ivan http://codereview.chromium.org/9124030/diff/1/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): http://codereview.chromium.org/9124030/diff/1/runtime/bin/bin.gypi#newcode1 runtime/bin/bin.gypi:1: # Copyright (c) ...
8 years, 11 months ago (2012-01-10 00:28:09 UTC) #2
Mads Ager (google)
Misunderstandings. We are in violent agreement that the copyrights should be updated. :-) http://codereview.chromium.org/9124030/diff/1/runtime/bin/bin.gypi File ...
8 years, 11 months ago (2012-01-10 06:55:05 UTC) #3
Ivan Posva
8 years, 11 months ago (2012-01-10 16:46:32 UTC) #4
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698