Issue 9124003: Dummy update to gypi file to force rebuild on buildbot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9124003: Dummy update to gypi file to force rebuild on buildbot (Closed)

Created:
8 years, 11 months ago by Søren Gjesse

Modified:
8 years, 11 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Dummy update to gypi file to force rebuild on buildbot TBR=ahe@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3032

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/bin/builtin_sources.gypi	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM :-) http://codereview.chromium.org/9124003/diff/1/runtime/bin/builtin_sources.gypi File runtime/bin/builtin_sources.gypi (right): http://codereview.chromium.org/9124003/diff/1/runtime/bin/builtin_sources.gypi#newcode61 runtime/bin/builtin_sources.gypi:61: 'globals.h', I think you need to remove ...

8 years, 11 months ago (2012-01-06 13:35:59 UTC) #2

Søren Gjesse

8 years, 11 months ago (2012-01-06 14:05:44 UTC) #3

http://codereview.chromium.org/9124003/diff/1/runtime/bin/builtin_sources.gypi
File runtime/bin/builtin_sources.gypi (right):

http://codereview.chromium.org/9124003/diff/1/runtime/bin/builtin_sources.gyp...
runtime/bin/builtin_sources.gypi:61: 'globals.h',
On 2012/01/06 13:35:59, ahe wrote:
> I think you need to remove this line ;-)

Why didn't you say this before :-?

Expand Messages | Collapse Messages