Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 9122003: Issue 1061: Duplicate members causes NPE in type analyzer (Closed)

Created:
8 years, 11 months ago by codefu
Modified:
8 years, 11 months ago
Reviewers:
messick, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 1061: Duplicate members causes NPE in type analyzer http://code.google.com/p/dart/issues/detail?id=1061 Replace Map<Element> with MultiMap<Element> (LinkedHashMap). R=zundel,messick BUG=1061 TEST= Committed: https://code.google.com/p/dart/source/detail?r=3047

Patch Set 1 #

Total comments: 2

Patch Set 2 : Search colliding set for field & method #

Patch Set 3 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java View 1 2 6 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
codefu
8 years, 11 months ago (2012-01-06 16:11:08 UTC) #1
codefu
http://codereview.chromium.org/9122003/diff/1/compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java File compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java (right): http://codereview.chromium.org/9122003/diff/1/compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java#newcode271 compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java:271: if(iterator.hasNext()) { Again, I fail to run the formatter.
8 years, 11 months ago (2012-01-06 16:14:16 UTC) #2
codefu
http://codereview.chromium.org/9122003/diff/1/compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java File compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java (right): http://codereview.chromium.org/9122003/diff/1/compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java#newcode278 compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java:278: Element element = lookupLocalElement(name); Do we want to update ...
8 years, 11 months ago (2012-01-06 16:21:13 UTC) #3
zundel
8 years, 11 months ago (2012-01-06 18:22:08 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698