Issue 9121014: Fix broken tests:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9121014: Fix broken tests: (Closed)

Created:
8 years, 11 months ago by Ivan Posva

Modified:
8 years, 11 months ago

Reviewers:
vsm, hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/tests/

Visibility:
Public.

More Reviews

Description

Fix broken tests: - For compilation to trigger a method has to be called. - operator [] is not allowed in compile time constants. - Trigger --compile_all for added verification. Committed: https://code.google.com/p/dart/source/detail?r=3058

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	language/src/CTConst2Test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	language/src/ConstInit7NegativeTest.dart	View	2 chunks	+3 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

LGTM http://codereview.chromium.org/9121014/diff/1/language/src/ConstInit7NegativeTest.dart File language/src/ConstInit7NegativeTest.dart (right): http://codereview.chromium.org/9121014/diff/1/language/src/ConstInit7NegativeTest.dart#newcode6 language/src/ConstInit7NegativeTest.dart:6: // VMOptions=--compile_all Is this actually used by the ...

8 years, 11 months ago (2012-01-06 21:41:42 UTC) #3

Ivan Posva

8 years, 11 months ago (2012-01-06 21:45:15 UTC) #4

http://codereview.chromium.org/9121014/diff/1/language/src/ConstInit7Negative...
File language/src/ConstInit7NegativeTest.dart (right):

http://codereview.chromium.org/9121014/diff/1/language/src/ConstInit7Negative...
language/src/ConstInit7NegativeTest.dart:6: // VMOptions=--compile_all
On 2012/01/06 21:41:42, vsm wrote:
> Is this actually used by the test script?

staine[runtime] ../tools/test.py --verbose language | grep
ConstInit7NegativeTest
Starting debugia32 vm language/ConstInit7NegativeTest...
# xcodebuild/Debug_ia32/dart --ignore-unrecognized-flags
/Sources/dart-quick/tests/language/src/ConstInit7NegativeTest.dart
Starting debugia32 vm language/ConstInit7NegativeTest...
# xcodebuild/Debug_ia32/dart --ignore-unrecognized-flags --compile_all
/Sources/dart-quick/tests/language/src/ConstInit7NegativeTest.dart
Done running debugia32 vm language/ConstInit7NegativeTest: PASS
Done running debugia32 vm language/ConstInit7NegativeTest: PASS

Expand Messages | Collapse Messages