Manually reapply changes to get around shadowing warning.

Manually reapply changes to get around stupid shadowing warning.

We really need a way to turn off specific warnings.  In this case, a
parameter shadows a method.  The code is automatically generated so
hard to change, and the names chosen are really the nicest ones for
the editor experience.

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3176

[sra1, 2012-01-11 02:06:52]

tbr

[mmendez, 2012-01-11 14:14:37]

On 2012/01/11 02:06:52, sra1 wrote:
> tbr

LGTM.  Gilad is looking into how to suppress specific warnings.

Konstantine, http://codereview.chromium.org/9149008/ should have made this
change unnecessary.  Can you take a look and see why this change was necessary
in light of your change?

[scheglov, 2012-01-11 15:11:01]

On 2012/01/11 14:14:37, mmendez wrote:
> On 2012/01/11 02:06:52, sra1 wrote:
> > tbr
> 
> LGTM.  Gilad is looking into how to suppress specific warnings.
> 
> Konstantine, http://codereview.chromium.org/9149008/ should have made this
> change unnecessary.  Can you take a look and see why this change was necessary
> in light of your change?

  I don't know exact reason.
  With http://codereview.chromium.org/9149008/ and
https://code.google.com/p/dart/source/detail?r=3146 I don't have any warning for
dom library.
  When I comment check for dom library and execute Project | Clean in Editor (I
run it directly from repository, not from integration build), then I see 
warning. When I restore check for dom, warning disappears.

  So, probably author of the patch uses older version of DartC.

[sra1, 2012-01-11 16:07:57]

On 2012/01/11 15:11:01, scheglov wrote:
> On 2012/01/11 14:14:37, mmendez wrote:
> > On 2012/01/11 02:06:52, sra1 wrote:
> > > tbr
> > 
> > LGTM.  Gilad is looking into how to suppress specific warnings.
> > 
> > Konstantine, http://codereview.chromium.org/9149008/ should have made this
> > change unnecessary.  Can you take a look and see why this change was
necessary
> > in light of your change?
> 
>   I don't know exact reason.
>   With http://codereview.chromium.org/9149008/ and
> https://code.google.com/p/dart/source/detail?r=3146 I don't have any warning
for
> dom library.
>   When I comment check for dom library and execute Project | Clean in Editor
(I
> run it directly from repository, not from integration build), then I see 
> warning. When I restore check for dom, warning disappears.
> 
>   So, probably author of the patch uses older version of DartC.

The issue is that the test script looks for .dart files and runs them for type
checks. I tried suppressing that but maybe I picked the wrong status file.

[mmendez, 2012-01-11 17:37:30]

I think that you would want to modify client/tests/dartc/dartc.status.  Is that
the one you tried?

On 2012/01/11 16:07:57, sra1 wrote:
> On 2012/01/11 15:11:01, scheglov wrote:
> > On 2012/01/11 14:14:37, mmendez wrote:
> > > On 2012/01/11 02:06:52, sra1 wrote:
> > > > tbr
> > > 
> > > LGTM.  Gilad is looking into how to suppress specific warnings.
> > > 
> > > Konstantine, http://codereview.chromium.org/9149008/ should have made this
> > > change unnecessary.  Can you take a look and see why this change was
> necessary
> > > in light of your change?
> > 
> >   I don't know exact reason.
> >   With http://codereview.chromium.org/9149008/ and
> > https://code.google.com/p/dart/source/detail?r=3146 I don't have any warning
> for
> > dom library.
> >   When I comment check for dom library and execute Project | Clean in Editor
> (I
> > run it directly from repository, not from integration build), then I see 
> > warning. When I restore check for dom, warning disappears.
> > 
> >   So, probably author of the patch uses older version of DartC.
> 
> The issue is that the test script looks for .dart files and runs them for type
> checks. I tried suppressing that but maybe I picked the wrong status file.