Record names of constructors and use that to implement Object.toString.

Record names of constructors and use that to implement Object.toString.

Committed: https://code.google.com/p/dart/source/detail?r=3183

[ahe, 2012-01-10 23:57:00]

You'll probably tell me this is wrong for a 100 different reasons. But I gotta
start somewhere :-)

Anyways, I'm looking forward to hearing what you think.

Cheers,
Peter

[floitsch, 2012-01-11 09:46:42]

LGTM.

[Lasse Reichstein, 2012-01-11 09:49:15]

LGTM with comments.

http://codereview.chromium.org/9114053/diff/1/dart/frog/leg/emitter.dart
File dart/frog/leg/emitter.dart (right):

http://codereview.chromium.org/9114053/diff/1/dart/frog/leg/emitter.dart#newc...
dart/frog/leg/emitter.dart:103: buffer.add('$className = function
${classElement.name}(');
I like having the name on the function for debugging, but wouldn't rely on it
being readable.
Instead add it as a property on the function object later.

http://codereview.chromium.org/9114053/diff/1/dart/frog/leg/emitter.dart#newc...
dart/frog/leg/emitter.dart:108: buffer.add('};\n');
E.g., here:
   buffer.add('$className.\$name = "${classElement.name}";');

http://codereview.chromium.org/9114053/diff/1/dart/frog/leg/lib/core.dart
File dart/frog/leg/lib/core.dart (right):

http://codereview.chromium.org/9114053/diff/1/dart/frog/leg/lib/core.dart#new...
dart/frog/leg/lib/core.dart:307: toString() => "[Instance of '${JS('String',
@'this.constructor.name')}']";
and @'this.constructor.$name' here.

http://codereview.chromium.org/9114053/diff/1/dart/frog/tests/leg_only/src/To...
File dart/frog/tests/leg_only/src/ToStringTest.dart (right):

http://codereview.chromium.org/9114053/diff/1/dart/frog/tests/leg_only/src/To...
dart/frog/tests/leg_only/src/ToStringTest.dart:10: Expect.equals("[Instance of
'A']", new A().toString());
If List.toString should return "Instance of 'List'", then test that here too,
just for good measure (even though it goes through the interceptor).

[ahe, 2012-01-11 11:01:23]

Hi Lasse and Florian,

Thank you for taking a look. I have uploaded a new version, please take another
look.

Cheers,
Peter

http://codereview.chromium.org/9114053/diff/1/dart/frog/leg/emitter.dart
File dart/frog/leg/emitter.dart (right):

http://codereview.chromium.org/9114053/diff/1/dart/frog/leg/emitter.dart#newc...
dart/frog/leg/emitter.dart:103: buffer.add('$className = function
${classElement.name}(');
On 2012/01/11 09:49:16, Lasse Reichstein wrote:
> I like having the name on the function for debugging, but wouldn't rely on it
> being readable.
> Instead add it as a property on the function object later.

It is readable on IE (with some additional tricks), Firefox, and V8.

[floitsch, 2012-01-11 11:52:39]

SLGTM.

http://codereview.chromium.org/9114053/diff/5002/dart/frog/leg/lib/core.dart
File dart/frog/leg/lib/core.dart (right):

http://codereview.chromium.org/9114053/diff/5002/dart/frog/leg/lib/core.dart#...
dart/frog/leg/lib/core.dart:51: if (JS("bool", @"typeof $0 === 'string'", b) ||
as discussed we should be able to just call b.toString.
But this can wait for another CL.

[ahe, 2012-01-11 12:29:04]

PTAL

[ngeoffray, 2012-01-11 12:30:13]

LGTM

http://codereview.chromium.org/9114053/diff/9001/dart/frog/leg/ssa/nodes.dart
File dart/frog/leg/ssa/nodes.dart (left):

http://codereview.chromium.org/9114053/diff/9001/dart/frog/leg/ssa/nodes.dart...
dart/frog/leg/ssa/nodes.dart:1200: if (type.isUnknown()) return HType.NUMBER;
Crying :-)

[ahe, 2012-01-11 14:30:40]

Before submitting, I had to make a few changes to the language status file (one
more test passing), and the golden output test
dart/frog/tests/leg/src/ClassCodegenTest.dart.