Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 9114008: Introduce runtime/platform directory for code shared between vm (Closed)

Created:
8 years, 11 months ago by Mads Ager (google)
Modified:
8 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Introduce runtime/platform directory for code shared between vm and bin. Cleaned up globals.h. Common parts now in platform/globals.h. vm specific parts are in vm/globals.h and bin/globals.h is gone. R=sgjesse@google.com,iposva@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3030

Patch Set 1 #

Patch Set 2 : Windows fixes. #

Total comments: 2

Patch Set 3 : Address comments. #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -351 lines) Patch
M runtime/bin/builtin.h View 1 chunk +2 lines, -1 line 2 comments Download
M runtime/bin/dartutils.h View 1 chunk +2 lines, -1 line 2 comments Download
M runtime/bin/dartutils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/directory.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/fdutils.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/file_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +2 lines, -1 line 0 comments Download
D runtime/bin/globals.h View 1 chunk +0 lines, -127 lines 0 comments Download
M runtime/bin/main.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/process.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/process_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/socket.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/thread_pool.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/thread_pool_linux.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/thread_pool_macos.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/thread_pool_win.h View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/platform/c99_support_win.h View 1 2 2 chunks +3 lines, -3 lines 2 comments Download
A + runtime/platform/globals.h View 1 2 3 chunks +25 lines, -47 lines 0 comments Download
A + runtime/platform/inttypes_support_win.h View 1 2 2 chunks +3 lines, -3 lines 2 comments Download
M runtime/vm/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
D runtime/vm/c99_support_win.h View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
M runtime/vm/code_index_table.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/globals.h View 1 4 chunks +5 lines, -86 lines 0 comments Download
D runtime/vm/inttypes_support_win.h View 1 2 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (google)
8 years, 11 months ago (2012-01-05 13:06:46 UTC) #1
Søren Gjesse
lgtm http://codereview.chromium.org/9114008/diff/2001/runtime/platform/globals.h File runtime/platform/globals.h (right): http://codereview.chromium.org/9114008/diff/2001/runtime/platform/globals.h#newcode44 runtime/platform/globals.h:44: #include "vm/c99_support_win.h" Move these .h files to platform/ ...
8 years, 11 months ago (2012-01-05 13:15:31 UTC) #2
Mads Ager (google)
http://codereview.chromium.org/9114008/diff/2001/runtime/platform/globals.h File runtime/platform/globals.h (right): http://codereview.chromium.org/9114008/diff/2001/runtime/platform/globals.h#newcode44 runtime/platform/globals.h:44: #include "vm/c99_support_win.h" On 2012/01/05 13:15:32, Søren Gjesse wrote: > ...
8 years, 11 months ago (2012-01-05 14:42:27 UTC) #3
Ivan Posva
Some particular comments and it is the time of the year again where I start ...
8 years, 11 months ago (2012-01-07 00:26:46 UTC) #4
Mads Ager (google)
8 years, 11 months ago (2012-01-07 08:24:32 UTC) #5
Thanks for the comments Ivan. I have addressed them in a separate CL:
http://codereview.chromium.org/9124030

Sorry for the gyp mess left by this change. I have introduced a
platform_source.gypi file and included that in the other projects. At this point
it is included wherever builtin_sources.gypi and vm_sources.gypi are included.
When we start having implementation files and not just header files in this
directory we should split into two gypi files so we only get the implementation
in the vm library but the header files in all of them.

Since I was not consistent with updating the copyright notice for all files I
edited I have reverted those changes. I do think that we should update the
copyright notices in the same way that the chromium and v8 projects do. Please
see http://www.chromium.org/developers/coding-style

"All source files in the Chromium project must start with the following header.
If you modify an old file, you must update the copyright to the current year
(not a range, i.e. don't use "2009-2011", even if the original code did).  There
is no need to change the copyright on files that are not otherwise being
modified."

http://codereview.chromium.org/9114008/diff/5001/runtime/bin/builtin.h
File runtime/bin/builtin.h (right):

http://codereview.chromium.org/9114008/diff/5001/runtime/bin/builtin.h#newcode12
runtime/bin/builtin.h:12: 
On 2012/01/07 00:26:46, Ivan Posva wrote:
> Why the extra line?

I guess I found that easier to read. I'll remove the ones I introduced. I'm
pretty sure that there are other places where the includes from the "include"
directory has its own section.

http://codereview.chromium.org/9114008/diff/5001/runtime/bin/dartutils.h
File runtime/bin/dartutils.h (right):

http://codereview.chromium.org/9114008/diff/5001/runtime/bin/dartutils.h#newc...
runtime/bin/dartutils.h:11: 
On 2012/01/07 00:26:46, Ivan Posva wrote:
> ditto, and other places

Done.

http://codereview.chromium.org/9114008/diff/5001/runtime/platform/c99_support...
File runtime/platform/c99_support_win.h (right):

http://codereview.chromium.org/9114008/diff/5001/runtime/platform/c99_support...
runtime/platform/c99_support_win.h:1: // Copyright (c) 2011, the Dart project
authors.  Please see the AUTHORS file
On 2012/01/07 00:26:46, Ivan Posva wrote:
> Please update the gypi files with the new location for this file.

Done.

http://codereview.chromium.org/9114008/diff/5001/runtime/platform/inttypes_su...
File runtime/platform/inttypes_support_win.h (right):

http://codereview.chromium.org/9114008/diff/5001/runtime/platform/inttypes_su...
runtime/platform/inttypes_support_win.h:1: // Copyright (c) 2011, the Dart
project authors.  Please see the AUTHORS file
On 2012/01/07 00:26:46, Ivan Posva wrote:
> ditto, update the gypi.

Done.

Powered by Google App Engine
This is Rietveld 408576698