Issue 9112012: Implement code generation for === and !==.

Issue 9112012: Implement code generation for === and !==. (Closed)

Created:
8 years, 11 months ago by karlklose

Modified:
8 years, 11 months ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org, Lasse Reichstein, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement code generation for === and !==. TEST=tests/leg/src/IdentityTest.dart Committed: https://code.google.com/p/dart/source/detail?r=3004

Patch Set 1 #

Patch Set 2 : Forget two things. #

Patch Set 3 : Fix a bug and update status files. #

Total comments: 4

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -23 lines)			Patch
M	frog/leg/lib/core.dart	View		1 chunk	+4 lines, -0 lines	1 comment	Download
M	frog/leg/resolver.dart	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	frog/leg/ssa/builder.dart	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download
M	frog/leg/ssa/codegen.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	frog/leg/ssa/nodes.dart	View	1 2	4 chunks	+22 lines, -2 lines	1 comment	Download
M	frog/leg/ssa/tracer.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	frog/tests/leg/src/IdentityTest.dart	View		1 chunk	+29 lines, -0 lines	1 comment	Download
M	tests/corelib/corelib-leg.status	View	1 2	2 chunks	+13 lines, -13 lines	0 comments	Download
M	tests/language/language-leg.status	View	1 2	6 chunks	+3 lines, -8 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

8 years, 11 months ago (2012-01-06 08:10:20 UTC) #3

DBC

http://codereview.chromium.org/9112012/diff/2002/frog/leg/lib/core.dart
File frog/leg/lib/core.dart (right):

http://codereview.chromium.org/9112012/diff/2002/frog/leg/lib/core.dart#newco...
frog/leg/lib/core.dart:123: eqq(var a, var b) {
Why this method if HIdentity always ends up being a builtin?

http://codereview.chromium.org/9112012/diff/2002/frog/leg/ssa/nodes.dart
File frog/leg/ssa/nodes.dart (right):

http://codereview.chromium.org/9112012/diff/2002/frog/leg/ssa/nodes.dart#newc...
frog/leg/ssa/nodes.dart:1666: bool evaluate(num a, num b) => a === b;
Should that be really 'num' here?

http://codereview.chromium.org/9112012/diff/2002/frog/tests/leg/src/IdentityT...
File frog/tests/leg/src/IdentityTest.dart (right):

http://codereview.chromium.org/9112012/diff/2002/frog/tests/leg/src/IdentityT...
frog/tests/leg/src/IdentityTest.dart:25: matches =
regexp.allMatches(generated).iterator();
There is a checkNumberOfMatches method in TypeGuardUnuserTest that could be
shared.

http://codereview.chromium.org/9112012/diff/2002/tests/language/language-leg....
File tests/language/language-leg.status (right):

http://codereview.chromium.org/9112012/diff/2002/tests/language/language-leg....
tests/language/language-leg.status:181: # InstantiateTypeVariableNegativeTest:
Fail  # Fails for the wrong reason.
Should it be 'Pass' for the wrong reason?

Expand Messages | Collapse Messages