Issue 9111019: Support for nested comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9111019: Support for nested comments (Closed)

Created:
8 years, 11 months ago by Jennifer Messerly

Modified:
8 years, 11 months ago

Reviewers:
jimhug

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support for nested comments Fixes http://code.google.com/p/dart/issues/detail?id=1044

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -18 lines)			Patch
M	frog/minfrog	View	1 chunk	+15 lines, -8 lines	0 comments	Download
M	frog/tokenizer.dart	View	2 chunks	+13 lines, -9 lines	1 comment	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jimhug

8 years, 11 months ago (2012-01-05 18:32:29 UTC) #2

lgtm

http://codereview.chromium.org/9111019/diff/1/frog/tokenizer.dart
File frog/tokenizer.dart (left):

http://codereview.chromium.org/9111019/diff/1/frog/tokenizer.dart#oldcode176
frog/tokenizer.dart:176: return _errorToken();
Nice to see this cleaned up as part of the change.

Expand Messages | Collapse Messages