Detect crashes in frog/leg (when running on VM).

Detect crashes in frog/leg (when running on VM).

Committed: https://code.google.com/p/dart/source/detail?r=2992

[ahe, 2012-01-05 11:50:50]

I may have to fiddle a little more with the status files before this CL can be
submitted.

[ahe, 2012-01-05 11:56:18]

In case it isn't obvious: frogc.dart and minfrogc.dart are Dart VM wrappers
around Frog. So reporting crashes only works on the VM.

Components "frog" and "leg" runs the compiler on the VM, components "frogsh" and
"frogium" runs the self-hosted compiler on node.js.

http://codereview.chromium.org/9111012/diff/1/dart/tests/isolate/isolate.status
File dart/tests/isolate/isolate.status (right):

http://codereview.chromium.org/9111012/diff/1/dart/tests/isolate/isolate.stat...
dart/tests/isolate/isolate.status:36: [ $component == frogium ]
For example, this should be frog, not frogium :-)

[ngeoffray, 2012-01-05 12:09:19]

LGTM, but

http://codereview.chromium.org/9111012/diff/1/dart/tests/isolate/isolate.status
File dart/tests/isolate/isolate.status (right):

http://codereview.chromium.org/9111012/diff/1/dart/tests/isolate/isolate.stat...
dart/tests/isolate/isolate.status:36: [ $component == frogium ]
On 2012/01/05 11:56:18, ahe wrote:
> For example, this should be frog, not frogium :-)

Please explain the comment. I don't understand why frogium (which does not run
on the VM) would now crash.

http://codereview.chromium.org/9111012/diff/1/dart/tests/language/language.st...
File dart/tests/language/language.status (right):

http://codereview.chromium.org/9111012/diff/1/dart/tests/language/language.st...
dart/tests/language/language.status:347: [ $component == frogsh || $component ==
frogium ]
Again, why are frogsh and frogium affected?

[ahe, 2012-01-05 12:14:44]

http://codereview.chromium.org/9111012/diff/1/dart/tests/isolate/isolate.status
File dart/tests/isolate/isolate.status (right):

http://codereview.chromium.org/9111012/diff/1/dart/tests/isolate/isolate.stat...
dart/tests/isolate/isolate.status:36: [ $component == frogium ]
On 2012/01/05 12:09:19, ngeoffray wrote:
> On 2012/01/05 11:56:18, ahe wrote:
> > For example, this should be frog, not frogium :-)
> 
> Please explain the comment. I don't understand why frogium (which does not run
> on the VM) would now crash.

This comment follows up to my first message where I said that I might need to
fiddle more with the status file (but I can see that context got completely
lost).

I made a mistake: it should be "frog", not "frogium" here. I have fixed that
locally, but not uploaded a new patch set yet.

http://codereview.chromium.org/9111012/diff/1/dart/tests/language/language.st...
File dart/tests/language/language.status (right):

http://codereview.chromium.org/9111012/diff/1/dart/tests/language/language.st...
dart/tests/language/language.status:347: [ $component == frogsh || $component ==
frogium ]
On 2012/01/05 12:09:19, ngeoffray wrote:
> Again, why are frogsh and frogium affected?

They aren't. I have moved these tests from a frog+frogsh+frogium section to a
frogsh+frogium section.