Issue 9110032: Fix test.dart on Frogium component, enable in buildbot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9110032: Fix test.dart on Frogium component, enable in buildbot. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
Søren Gjesse, Mads Ager (google), ahe, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix test.dart on Frogium component, enable in buildbot. BUG= TEST=cd frog; ../tools/build.py; ../tools/test.py -cfrogium frog Committed: https://code.google.com/p/dart/source/detail?r=3042

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	frog/scripts/buildbot_annotated_steps.py	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 11 months ago (2012-01-06 15:23:05 UTC) #3

LGTM!

http://codereview.chromium.org/9110032/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9110032/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:355: dartDir.endsWith('/frog')) {
This looks like a hack, but I guess you know what you're doing.

Expand Messages | Collapse Messages