Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 9110030: Add back bin/globals.h to help buildbot (Closed)

Created:
8 years, 11 months ago by Søren Gjesse
Modified:
8 years, 11 months ago
Reviewers:
ahe, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add back bin/globals.h to help buildbot TBR=ahe@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3034

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A runtime/bin/globals.h View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
8 years, 11 months ago (2012-01-06 13:00:14 UTC) #1
ahe
LGTM!
8 years, 11 months ago (2012-01-06 13:36:30 UTC) #2
Ivan Posva
http://codereview.chromium.org/9110030/diff/1/runtime/bin/globals.h File runtime/bin/globals.h (right): http://codereview.chromium.org/9110030/diff/1/runtime/bin/globals.h#newcode1 runtime/bin/globals.h:1: // Copyright (c) 2012, the Dart project authors. Please ...
8 years, 11 months ago (2012-01-07 00:18:15 UTC) #3
ahe
http://codereview.chromium.org/9110030/diff/1/runtime/bin/globals.h File runtime/bin/globals.h (right): http://codereview.chromium.org/9110030/diff/1/runtime/bin/globals.h#newcode1 runtime/bin/globals.h:1: // Copyright (c) 2012, the Dart project authors. Please ...
8 years, 11 months ago (2012-01-07 00:24:45 UTC) #4
Ivan Posva
8 years, 11 months ago (2012-01-07 00:27:49 UTC) #5
On 2012/01/07 00:24:45, ahe wrote:
> http://codereview.chromium.org/9110030/diff/1/runtime/bin/globals.h
> File runtime/bin/globals.h (right):
> 
> http://codereview.chromium.org/9110030/diff/1/runtime/bin/globals.h#newcode1
> runtime/bin/globals.h:1: // Copyright (c) 2012, the Dart project authors. 
> Please see the AUTHORS file
> On 2012/01/07 00:18:15, Ivan Posva wrote:
> > I don't understand why this file is necessary. Please remove it.
> > 
> > -Ivan
> 
> That already happened. We managed to confuse ourselves with this problem while
> Mads was doing a job interview. 
> 
> Eventually, we realized that it was simply that Mads forgot to remove this
file
> from sources.gypi. But not before we had fooled around a bit.

Ok, thanks for the update.

-Ivan

Powered by Google App Engine
This is Rietveld 408576698