Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 9109019: Fix for an NPE for cases where the native keyword on a class is not followed by a string identifier. (Closed)

Created:
8 years, 11 months ago by devoncarew
Modified:
8 years, 11 months ago
Reviewers:
codefu, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for an NPE for cases where the native keyword on a class is not followed by a string identifier. Committed: https://code.google.com/p/dart/source/detail?r=3011

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
devoncarew
This is causing an NPE when trying to compiler dartdoc.dart (one of the files it ...
8 years, 11 months ago (2012-01-05 18:55:42 UTC) #1
codefu
lgtm
8 years, 11 months ago (2012-01-05 18:58:32 UTC) #2
Brian Wilkerson
8 years, 11 months ago (2012-01-05 21:08:06 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698