Issue 9108036: - Remove redundant initialization in Array::New

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9108036: - Remove redundant initialization in Array::New (Closed)

Created:
8 years, 11 months ago by siva

Modified:
8 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Remove redundant initialization in Array::New - Add timer for measuing isolate initialization Committed: https://code.google.com/p/dart/source/detail?r=3063

Patch Set 3 : '' #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -8 lines)			Patch
M	vm/dart.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	vm/object.cc	View	1 2	2 chunks	+0 lines, -8 lines	0 comments	Download
M	vm/timer.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comment. -Ivan http://codereview.chromium.org/9108036/diff/1/vm/object.cc File vm/object.cc (right): http://codereview.chromium.org/9108036/diff/1/vm/object.cc#newcode5281 vm/object.cc:5281: while (offset < instance_size) { ...

8 years, 11 months ago (2012-01-06 21:40:05 UTC) #2

siva

8 years, 11 months ago (2012-01-07 00:01:02 UTC) #3

http://codereview.chromium.org/9108036/diff/1/vm/object.cc
File vm/object.cc (right):

http://codereview.chromium.org/9108036/diff/1/vm/object.cc#newcode5281
vm/object.cc:5281: while (offset < instance_size) {
Good point. Done.

On 2012/01/06 21:40:05, Ivan Posva wrote:
> This could be dropped as well.

http://codereview.chromium.org/9108036/diff/1/vm/object.cc#newcode7115
vm/object.cc:7115: // Object::Allocate has already initialized the allocated
area.
On 2012/01/06 21:40:05, Ivan Posva wrote:
> Comment can be dropped, no?

Done.

Expand Messages | Collapse Messages

Issue 9108036: - Remove redundant initialization in Array::New (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages