fix Library*NegativeTests (and a couple Prefix ones by accident)

fix Library*NegativeTests (and a couple Prefix ones by accident)

In general, this change felt fine to make in frog; however, it felt REALLY ugly to make the required fixes to the dartdoc tests.  I suppose this just raises the priority of our packaging and library story.

Committed: https://code.google.com/p/dart/source/detail?r=3222

[Bob Nystrom, 2012-01-12 01:25:35]

Ouch.

http://codereview.chromium.org/9107031/diff/3001/utils/tests/dartdoc/src/dart...
File utils/tests/dartdoc/src/dartdoc_tests.dart (right):

http://codereview.chromium.org/9107031/diff/3001/utils/tests/dartdoc/src/dart...
utils/tests/dartdoc/src/dartdoc_tests.dart:8:
#import('../../../dartdoc/dartdoc.dart', prefix: 'dd');
What (unused) names are colliding here? Can we prefix frog instead?

[Jennifer Messerly, 2012-01-12 01:58:33]

lgtm

http://codereview.chromium.org/9107031/diff/3001/frog/library.dart
File frog/library.dart (right):

http://codereview.chromium.org/9107031/diff/3001/frog/library.dart#newcode72
frog/library.dart:72: // Special exemption in spec to ensure core is only
imported once
Is this to avoid our implicit import of dart:core conflicting with explicit
import?

http://codereview.chromium.org/9107031/diff/3001/frog/library.dart#newcode230
frog/library.dart:230: Member lookup(String name, SourceSpan span) {
Member lookup(String name, SourceSpan span) => _topNames[name];

http://codereview.chromium.org/9107031/diff/3001/frog/member.dart
File frog/member.dart (right):

http://codereview.chromium.org/9107031/diff/3001/frog/member.dart#newcode230
frog/member.dart:230: SourceSpan get span() => type.definition === null ? null :
type.definition.span;
long line

http://codereview.chromium.org/9107031/diff/3001/utils/tests/dartdoc/src/dart...
File utils/tests/dartdoc/src/dartdoc_tests.dart (right):

http://codereview.chromium.org/9107031/diff/3001/utils/tests/dartdoc/src/dart...
utils/tests/dartdoc/src/dartdoc_tests.dart:8:
#import('../../../dartdoc/dartdoc.dart', prefix: 'dd');
I would've called this "doc" personally