Issue 9091006: Allow using '--option value' as well as '--option=value' in dart test script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9091006: Allow using '--option value' as well as '--option=value' in dart test script. (Closed)

Created:
8 years, 11 months ago by Mads Ager (google)

Modified:
8 years, 11 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow using '--option value' as well as '--option=value' in dart test script. R=whesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2945

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	tools/testing/dart/test_options.dart	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

LGTM. Do you want to add a test to say that --component --mode debug would ...

8 years, 11 months ago (2012-01-04 14:42:35 UTC) #2

Mads Ager (google)

8 years, 11 months ago (2012-01-04 14:48:49 UTC) #3

On 2012/01/04 14:42:35, Bill Hesse wrote:
> LGTM.  Do you want to add a test to say that --component --mode debug would be
> an error? (a string starting with -- as a value?)

I don't have to. All the options have a list of recognized values. Therefore,
--component --mode will already fail and say that --mode is an unknown value for
--component.

Expand Messages | Collapse Messages