Issue 9087011: Clean up test.dart by merging dartium and chromium test case generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9087011: Clean up test.dart by merging dartium and chromium test case generation. (Closed)

Created:
8 years, 11 months ago by Bill Hesse

Modified:
8 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clean up test.dart by merging dartium and chromium test case generation. BUG= TEST=tools/test.dart -cchromium,dartium,frogium Committed: https://code.google.com/p/dart/source/detail?r=2983

Patch Set 2 : Merge in FileMode changes. #

Patch Set 3 : Restore getHtmlName for client tests. #

Total comments: 3

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -137 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View	1 2	7 chunks	+63 lines, -137 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm http://codereview.chromium.org/9087011/diff/4/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): http://codereview.chromium.org/9087011/diff/4/tools/testing/dart/test_suite.dart#newcode361 tools/testing/dart/test_suite.dart:361: // All variables are block local, except tempDir. ...

8 years, 11 months ago (2012-01-04 22:03:21 UTC) #2

Bill Hesse

8 years, 11 months ago (2012-01-05 09:28:17 UTC) #3

http://codereview.chromium.org/9087011/diff/4/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9087011/diff/4/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:266: enqueueBrowserTest(filename,
testName,optionsFromFile,
Oops - missing space.

http://codereview.chromium.org/9087011/diff/4/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:361: // All variables are block local, except
tempDir.
Moved to a separate function.

On 2012/01/04 22:03:23, Mads Ager wrote:
> I'm not sure there is value in the extra scope here? Maybe you should be
> extracting things into separate functions if you feel this is getting big
enough
> that you want to do this?