Add python wrapper for test.dart.

Add python wrapper for test.dart.

Use test.dart (through the wrapper) for all frog testing both
for developers and on the buildbot.

Will commit this once the frogium tests have been fixed to be
runable from the frog directory.

R=whesse@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3026

[Bill Hesse, 2012-01-04 15:11:08]

LGTM.  The long line is fixed, I see.

http://codereview.chromium.org/9086008/diff/1/tools/test_wrapper.py
File tools/test_wrapper.py (right):

http://codereview.chromium.org/9086008/diff/1/tools/test_wrapper.py#newcode24
tools/test_wrapper.py:24: args = string.join(sys.argv[1:])
This shouldn't be a problem here, but in test.dart we create commands with
arguments containing spaces, that aren't surrounded by quotes.  Maybe we should
fix that, since it makes it hard to copy and paste commands, and this type of
args manipulation breaks.

http://codereview.chromium.org/9086008/diff/1/tools/testing/dart/test_options...
File tools/testing/dart/test_options.dart (right):

http://codereview.chromium.org/9086008/diff/1/tools/testing/dart/test_options...
tools/testing/dart/test_options.dart:297: // Use verbose progress indication for
verbose output unless buildbot progress
Is this line too long?

[ahe, 2012-01-04 15:38:40]

LGTM!

http://codereview.chromium.org/9086008/diff/3001/tools/test_wrapper.py
File tools/test_wrapper.py (right):

http://codereview.chromium.org/9086008/diff/3001/tools/test_wrapper.py#newcode13
tools/test_wrapper.py:13: def GuessOS():
Any reason for not importing this from utils.py?

http://codereview.chromium.org/9086008/diff/3001/tools/test_wrapper.py#newcode29
tools/test_wrapper.py:29: dart_binary = string.join([tools_dir, 'testing',
'bin', GuessOS(), 'dart'],
os.path.join(tools_dir, 'testing', 'bin', GuessOS(), 'dart')

http://codereview.chromium.org/9086008/diff/3001/tools/test_wrapper.py#newcode34
tools/test_wrapper.py:34: command = "%s %s %s" % (dart_binary, dart_test_script,
args)
command = [dart_binary, dart_test_script] + args

[Mads Ager (google), 2012-01-05 14:15:42]

http://codereview.chromium.org/9086008/diff/3001/tools/test_wrapper.py
File tools/test_wrapper.py (right):

http://codereview.chromium.org/9086008/diff/3001/tools/test_wrapper.py#newcode13
tools/test_wrapper.py:13: def GuessOS():
On 2012/01/04 15:38:40, ahe wrote:
> Any reason for not importing this from utils.py?

I had two reasons:

1. I want to return 'windows' and not 'win32'.
2. I would like to get rid of as much python code as possible.

None of these are critical. I can just test for win32 explicitly and I actually
think it will be a while before we can get rid of utils.py in any case. Let's
just import utils for now.

http://codereview.chromium.org/9086008/diff/3001/tools/test_wrapper.py#newcode29
tools/test_wrapper.py:29: dart_binary = string.join([tools_dir, 'testing',
'bin', GuessOS(), 'dart'],
On 2012/01/04 15:38:40, ahe wrote:
> os.path.join(tools_dir, 'testing', 'bin', GuessOS(), 'dart')

Thanks! Done.

http://codereview.chromium.org/9086008/diff/3001/tools/test_wrapper.py#newcode34
tools/test_wrapper.py:34: command = "%s %s %s" % (dart_binary, dart_test_script,
args)
On 2012/01/04 15:38:40, ahe wrote:
> command = [dart_binary, dart_test_script] + args

Done.

[ahe, 2012-01-05 14:19:52]

http://codereview.chromium.org/9086008/diff/3001/tools/test_wrapper.py
File tools/test_wrapper.py (right):

http://codereview.chromium.org/9086008/diff/3001/tools/test_wrapper.py#newcode13
tools/test_wrapper.py:13: def GuessOS():
On 2012/01/05 14:15:45, Mads Ager wrote:
> On 2012/01/04 15:38:40, ahe wrote:
> > Any reason for not importing this from utils.py?
> 
> I had two reasons:
> 
> 1. I want to return 'windows' and not 'win32'.
> 2. I would like to get rid of as much python code as possible.
> 
> None of these are critical. I can just test for win32 explicitly and I
actually
> think it will be a while before we can get rid of utils.py in any case. Let's
> just import utils for now.

Thank you!