Issue 9072004: Make sure to close when _BaseDataInputStream reaches the end

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9072004: Make sure to close when _BaseDataInputStream reaches the end (Closed)

Created:
8 years, 11 months ago by Søren Gjesse

Modified:
8 years, 11 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sure to close when _BaseDataInputStream reaches the end This will close the opened file used by a FileInputStream when the input stream is read to the end. Should get rid of the current Windows buildbot redness. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2907

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	runtime/bin/file_impl.dart	View		2 chunks	+5 lines, -3 lines	0 comments	Download
	M	runtime/bin/stream_util.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages