Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 9035008: Do not generate at use site loop phis. It requires live analysis that we currently don't implement. (Closed)

Created:
9 years ago by ngeoffray
Modified:
9 years ago
Reviewers:
karlklose, floitsch, kasperl
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, ahe
Visibility:
Public.

Description

Do not generate at use site loop phis. It requires live analysis that we currently don't implement. Committed: https://code.google.com/p/dart/source/detail?r=2808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -34 lines) Patch
M frog/leg/ssa/phi_eliminator.dart View 4 chunks +3 lines, -25 lines 0 comments Download
M frog/tests/leg/src/SsaPhiEliminatorTest.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M frog/tests/leg/src/TypeInferenceTest.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M frog/tests/leg_only/leg_only.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language-leg.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
9 years ago (2011-12-23 13:47:57 UTC) #1
karlklose
9 years ago (2011-12-23 14:18:54 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698