Issue 9025024: Changes to testing script so we can run on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9025024: Changes to testing script so we can run on Windows. (Closed)

Created:
9 years ago by Emily Fortuna

Modified:
9 years ago

Reviewers:
Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Changes to testing script so we can run on Windows. Committed: https://code.google.com/p/dart/source/detail?r=2785

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -36 lines)			Patch
	M	tools/testing/perf_testing/create_graph.py	View	1 2	6 chunks	+40 lines, -36 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

9 years ago (2011-12-22 19:54:12 UTC) #2

lgtm

http://codereview.chromium.org/9025024/diff/2001/tools/testing/perf_testing/c...
File tools/testing/perf_testing/create_graph.py (right):

http://codereview.chromium.org/9025024/diff/2001/tools/testing/perf_testing/c...
tools/testing/perf_testing/create_graph.py:24: TOOLS_PATH =
os.path.join(os.path.dirname(os.path.dirname(os.path.dirname(
personally I'd do "from os.path import join, dirname, abspath" ... should make
this a bit shorter.

http://codereview.chromium.org/9025024/diff/2001/tools/testing/perf_testing/c...
tools/testing/perf_testing/create_graph.py:112: #Remove the xcode directory and
attempt to build again. If it still
should this say "Remove the output directory?"

Expand Messages | Collapse Messages