Issue 9024008: Change the process API to be completely asynchronous.

Issue 9024008: Change the process API to be completely asynchronous. (Closed)

Created:
9 years ago by Mads Ager (google)

Modified:
9 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change the process API to be completely asynchronous. Some of the implementation is still not asynchronous but the API is now prepared for it. This is a breaking change for the dart test scripts. Once the change has its final form I will add new stable builds of the VM to the changelist for running tests. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=2753

Patch Set 1 #

Patch Set 2 : Presubmit fixes #

Total comments: 8

Patch Set 3 : Address comments. #

Patch Set 4 : Add binaries. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+233 lines, -237 lines)			Patch
M	runtime/bin/process.dart	View	1	2 chunks	+38 lines, -23 lines	0 comments	Download
M	runtime/bin/process_impl.dart	View	1 2 3	7 chunks	+61 lines, -35 lines	0 comments	Download
M	samples/total/src/Dartc.dart	View		1 chunk	+4 lines, -7 lines	0 comments	Download
M	samples/total/src/TotalRunner.dart	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	tests/standalone/src/ProcessBrokenPipe.dart	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	tests/standalone/src/ProcessExitNegativeTest.dart	View	1 2 3	1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/standalone/src/ProcessExitTest.dart	View		1 chunk	+5 lines, -13 lines	0 comments	Download
M	tests/standalone/src/ProcessInvalidArgumentsTest.dart	View	1 2	1 chunk	+6 lines, -30 lines	0 comments	Download
M	tests/standalone/src/ProcessSegfaultTest.dart	View		1 chunk	+5 lines, -13 lines	0 comments	Download
M	tests/standalone/src/ProcessStartExceptionTest.dart	View	1 2	1 chunk	+10 lines, -23 lines	0 comments	Download
M	tests/standalone/src/ProcessStderrTest.dart	View	1	2 chunks	+33 lines, -30 lines	0 comments	Download
M	tests/standalone/src/ProcessStdoutTest.dart	View	1	2 chunks	+33 lines, -29 lines	0 comments	Download
M	tests/stub-generator/test_config.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/testing/bin/linux/dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/macos/dart	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/bin/windows/dart.exe	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/dart/test_runner.dart	View		5 chunks	+29 lines, -20 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm http://codereview.chromium.org/9024008/diff/2001/tests/standalone/src/ProcessInvalidArgumentsTest.dart File tests/standalone/src/ProcessInvalidArgumentsTest.dart (right): http://codereview.chromium.org/9024008/diff/2001/tests/standalone/src/ProcessInvalidArgumentsTest.dart#newcode7 tests/standalone/src/ProcessInvalidArgumentsTest.dart:7: void testNonStringPath() { Maybe Expect.throws(( ) => Process ...

9 years ago (2011-12-22 12:49:28 UTC) #2

Mads Ager (google)

9 years ago (2011-12-22 12:56:13 UTC) #3

http://codereview.chromium.org/9024008/diff/2001/tests/standalone/src/Process...
File tests/standalone/src/ProcessInvalidArgumentsTest.dart (right):

http://codereview.chromium.org/9024008/diff/2001/tests/standalone/src/Process...
tests/standalone/src/ProcessInvalidArgumentsTest.dart:7: void
testNonStringPath() {
On 2011/12/22 12:49:28, Søren Gjesse wrote:
> Maybe
> 
> Expect.throws(( ) => Process p = new Process.start(["true"], []),
>               (e) => e is ProcessException);

Done for all of them and inlined the three cases in main to make the test
simpler and smaller.

http://codereview.chromium.org/9024008/diff/2001/tests/standalone/src/Process...
tests/standalone/src/ProcessInvalidArgumentsTest.dart:18: Process p = new
Process.start("true", "asdf");
On 2011/12/22 12:49:28, Søren Gjesse wrote:
> Ditto.

Done.

http://codereview.chromium.org/9024008/diff/2001/tests/standalone/src/Process...
tests/standalone/src/ProcessInvalidArgumentsTest.dart:27: Process p = new
Process.start("true", ["asdf", 1]);
On 2011/12/22 12:49:28, Søren Gjesse wrote:
> Ditto.

Done.

http://codereview.chromium.org/9024008/diff/2001/tests/standalone/src/Process...
File tests/standalone/src/ProcessStartExceptionTest.dart (right):

http://codereview.chromium.org/9024008/diff/2001/tests/standalone/src/Process...
tests/standalone/src/ProcessStartExceptionTest.dart:29:
ProcessStartExceptionTest.testMain();
On 2011/12/22 12:49:28, Søren Gjesse wrote:
> Maybe just
> 
> ProcessStartExceptionTest.testStartError()
> 
> and remove
> 
> ProcessStartExceptionTest.testMain()

Done.

Expand Messages | Collapse Messages