Issue 9022004: Enable frogium component in test.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9022004: Enable frogium component in test.dart. (Closed)

Created:
9 years ago by Bill Hesse

Modified:
9 years ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable frogium component in test.dart. BUG= TEST=tools/test.dart --component=frogium Committed: https://code.google.com/p/dart/source/detail?r=2765

Patch Set 1 #

Total comments: 4

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -47 lines)			Patch
	M	tools/testing/dart/test_options.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/testing/dart/test_suite.dart	View		10 chunks	+84 lines, -46 lines	4 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

http://codereview.chromium.org/9022004/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): http://codereview.chromium.org/9022004/diff/1/tools/testing/dart/test_suite.dart#newcode260 tools/testing/dart/test_suite.dart:260: enqueueDartiumTest(filename, testName, optionsFromFile, I plan to merge Dartium and ...

9 years ago (2011-12-22 13:26:02 UTC) #1

Mads Ager (google)

9 years ago (2011-12-22 15:22:59 UTC) #2

LGTM!

http://codereview.chromium.org/9022004/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9022004/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:266: expectations, isNegative);
indentation.

http://codereview.chromium.org/9022004/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:458: String domInWrapper = 'dart:dom';
How about domLibraryImport? I think the name should be a bit more specific.

Expand Messages | Collapse Messages