Issue 9021042: Make snapshots 32 or 64 bit compliant by using Write<int64_t> and Read<int64_t> for intptr_t type...

Issue 9021042: Make snapshots 32 or 64 bit compliant by using Write<int64_t> and Read<int64_t> for intptr_t type... (Closed)

Created:
9 years ago by siva

Modified:
8 years, 12 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Make snapshots 32 or 64 bit compliant by using Write<int64_t> and Read<int64_t> for intptr_t types and adjust Smi values into Smi/Mint or BigInt based on the value read. Committed: https://code.google.com/p/dart/source/detail?r=2838

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 6

Patch Set 5 : '' #

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -72 lines)			Patch
M	vm/bitfield.h	View	1 2 3 4	3 chunks	+6 lines, -4 lines	0 comments	Download
M	vm/globals.h	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	vm/raw_object_snapshot.cc	View	1 2 3	26 chunks	+50 lines, -50 lines	0 comments	Download
M	vm/snapshot.h	View	1 2 3 4	4 chunks	+25 lines, -7 lines	0 comments	Download
M	vm/snapshot.cc	View	1 2 3 4	6 chunks	+13 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan http://codereview.chromium.org/9021042/diff/11001/vm/bitfield.h File vm/bitfield.h (right): http://codereview.chromium.org/9021042/diff/11001/vm/bitfield.h#newcode17 vm/bitfield.h:17: return (static_cast<uword>(value) & ~((1UL << ...

8 years, 12 months ago (2011-12-27 22:27:58 UTC) #3

siva

8 years, 12 months ago (2011-12-27 23:47:20 UTC) #4

http://codereview.chromium.org/9021042/diff/11001/vm/bitfield.h
File vm/bitfield.h (right):

http://codereview.chromium.org/9021042/diff/11001/vm/bitfield.h#newcode17
vm/bitfield.h:17: return (static_cast<uword>(value) & ~((1UL << size) - 1)) ==
0;
On 2011/12/27 22:27:59, Ivan Posva wrote:
> How about turning 1UL into a static const uword?

Done.

http://codereview.chromium.org/9021042/diff/11001/vm/snapshot.cc
File vm/snapshot.cc (right):

http://codereview.chromium.org/9021042/diff/11001/vm/snapshot.cc#newcode60
vm/snapshot.cc:60: ASSERT((value <= LONG_MAX) && (value >= LONG_MIN));
On 2011/12/27 22:27:59, Ivan Posva wrote:
> ditto

Done.

http://codereview.chromium.org/9021042/diff/11001/vm/snapshot.h
File vm/snapshot.h (right):

http://codereview.chromium.org/9021042/diff/11001/vm/snapshot.h#newcode302
vm/snapshot.h:302: ASSERT((value <= LONG_MAX) && (value >= LONG_MIN));
On 2011/12/27 22:27:59, Ivan Posva wrote:
> As discussed we should use the correct constant for intptr_t.

Done.

Expand Messages | Collapse Messages