Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 9020028: Hook up favicon, link to main page, and fix process bug. (Closed)

Created:
9 years ago by Bob Nystrom
Modified:
9 years ago
Reviewers:
Emily Fortuna, sethladd
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Hook up favicon, link to main page, and fix process bug. Committed: https://code.google.com/p/dart/source/detail?r=2735

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Add footer and analytics links for API docs. #

Patch Set 4 : r #

Total comments: 2

Patch Set 5 : Respond to review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -320 lines) Patch
M utils/apidoc/apidoc.dart View 1 2 2 chunks +42 lines, -1 line 0 comments Download
D utils/apidoc/static/header-background.jpeg View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
D utils/apidoc/static/styles.css View 1 2 3 1 chunk +0 lines, -310 lines 0 comments Download
M utils/dartdoc/dartdoc.dart View 1 2 3 4 5 chunks +32 lines, -9 lines 0 comments Download
A utils/dartdoc/static/favicon.ico View 0 chunks +-1 lines, --1 lines 0 comments Download
M utils/dartdoc/static/styles.css View 1 2 3 4 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
In addition to the original description, this patch also: - Adds the footer text that ...
9 years ago (2011-12-21 22:17:45 UTC) #1
Emily Fortuna
lgtm! http://codereview.chromium.org/9020028/diff/27/utils/dartdoc/static/styles.css File utils/dartdoc/static/styles.css (right): http://codereview.chromium.org/9020028/diff/27/utils/dartdoc/static/styles.css#newcode187 utils/dartdoc/static/styles.css:187: .footer { I'm going to make one more ...
9 years ago (2011-12-21 23:23:32 UTC) #2
Bob Nystrom
9 years ago (2011-12-21 23:35:07 UTC) #3
Thanks! Fixed the busted column and uploaded to go/dartdocs.

http://codereview.chromium.org/9020028/diff/27/utils/dartdoc/static/styles.css
File utils/dartdoc/static/styles.css (right):

http://codereview.chromium.org/9020028/diff/27/utils/dartdoc/static/styles.cs...
utils/dartdoc/static/styles.css:187: .footer {
On 2011/12/21 23:23:33, Emily Fortuna wrote:
> I'm going to make one more preference for the data on the page to be the same
> length as the menu bar (see
> http://www.corp.google.com/%7Ernystrom/docs/dart_coreimpl/IsolateContext.html
> looks awkward to me), and having the copyright stuff also on the page like
> dartlang, but I can be persuaded otherwise.

Oh, crap, that's a bug. Thanks for noticing. It's definitely not supposed to
look like that. The content and nav areas should always be the same height. What
it doesn't do is always be *screen* height if both the nav and the content are
short. Fixed.

Powered by Google App Engine
This is Rietveld 408576698