Support !=.

Support !=.
Committed: https://code.google.com/p/dart/source/detail?r=2698

[ahe, 2011-12-21 14:15:32]

LGTM!

http://codereview.chromium.org/9020010/diff/1/dart/frog/leg/resolver.dart
File dart/frog/leg/resolver.dart (right):

http://codereview.chromium.org/9020010/diff/1/dart/frog/leg/resolver.dart#new...
dart/frog/leg/resolver.dart:270: unreachable();
Not unreachable.

http://codereview.chromium.org/9020010/diff/1/dart/frog/tests/leg_only/src/No...
File dart/frog/tests/leg_only/src/NotEqualsTest.dart (right):

http://codereview.chromium.org/9020010/diff/1/dart/frog/tests/leg_only/src/No...
dart/frog/tests/leg_only/src/NotEqualsTest.dart:13: if (x != y) throw "3 != 3";
You could implement != as "false" and this test would still pass.

I suggest you add a case like this:

if (x != z) {
  print('good');
} else {
  throw 'x == z';
}

[ngeoffray, 2011-12-21 14:27:05]

Thanks Peter for having taken a look.

http://codereview.chromium.org/9020010/diff/1/dart/frog/leg/resolver.dart
File dart/frog/leg/resolver.dart (right):

http://codereview.chromium.org/9020010/diff/1/dart/frog/leg/resolver.dart#new...
dart/frog/leg/resolver.dart:270: unreachable();
On 2011/12/21 14:15:33, ahe wrote:
> Not unreachable.

Done.

http://codereview.chromium.org/9020010/diff/1/dart/frog/tests/leg_only/src/No...
File dart/frog/tests/leg_only/src/NotEqualsTest.dart (right):

http://codereview.chromium.org/9020010/diff/1/dart/frog/tests/leg_only/src/No...
dart/frog/tests/leg_only/src/NotEqualsTest.dart:13: if (x != y) throw "3 != 3";
On 2011/12/21 14:15:33, ahe wrote:
> You could implement != as "false" and this test would still pass.
> 
> I suggest you add a case like this:
> 
> if (x != z) {
>   print('good');
> } else {
>   throw 'x == z';
> }

Good point. Done.

[floitsch, 2011-12-21 15:46:21]

LGTM.

[ahe, 2012-01-03 18:01:49]

FYI

http://codereview.chromium.org/9020010/diff/1/dart/frog/leg/resolver.dart
File dart/frog/leg/resolver.dart (right):

http://codereview.chromium.org/9020010/diff/1/dart/frog/leg/resolver.dart#new...
dart/frog/leg/resolver.dart:270: unreachable();
On 2011/12/21 14:27:06, ngeoffray wrote:
> On 2011/12/21 14:15:33, ahe wrote:
> > Not unreachable.
> 
> Done.

Well, not really. We need to remember to pass a node, token, or HInstruction to
compiler.unimplemented. I know you have done that later, but I'm just taking
this opportunity to remind every one about the importance of good error messages
(even when you're crashing).