Issue 9019029: Retrieve value of local variables in stack frames.

Issue 9019029: Retrieve value of local variables in stack frames. (Closed)

Created:
9 years ago by hausner

Modified:
9 years ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Retrieve value of local variables in stack frames. Works for stack-based variables. Need more work to distinguish between stack and context (captured) variables. Committed: https://code.google.com/p/dart/source/detail?r=2736

Patch Set 1 #

Total comments: 18

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -78 lines)			Patch
M	runtime/vm/debugger.h	View	1	3 chunks	+18 lines, -23 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1	9 chunks	+55 lines, -55 lines	0 comments	Download
A	runtime/vm/debugger_arm.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A	runtime/vm/debugger_ia32.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
A	runtime/vm/debugger_x64.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

A small step, adding the capability to fetch values from the stack.

9 years ago (2011-12-21 21:33:02 UTC) #1

siva

lgtm http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger.cc#newcode76 runtime/vm/debugger.cc:76: /*locals_(NULL)*/ var_descriptors_(NULL), Why is the commented out locals_ ...

9 years ago (2011-12-22 00:04:28 UTC) #2

hausner

9 years ago (2011-12-22 00:15:31 UTC) #3

Thank you.

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger.cc#newcode76
runtime/vm/debugger.cc:76: /*locals_(NULL)*/ var_descriptors_(NULL),
On 2011/12/22 00:04:28, asiva wrote:
> Why is the commented out locals_ stuff needed?

Oops, leftover code. Removed.

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger.cc#newcode114
runtime/vm/debugger.cc:114: Function& func = DartFunction();
On 2011/12/22 00:04:28, asiva wrote:
> const Function& func = ...

Done.

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger.cc#newcode211
runtime/vm/debugger.cc:211: Function& func = DartFunction();
On 2011/12/22 00:04:28, asiva wrote:
> const Function& func = ...?

Done.

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger.h
File runtime/vm/debugger.h (right):

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger.h#newcode58
runtime/vm/debugger.h:58: Function& DartFunction();
On 2011/12/22 00:04:28, asiva wrote:
> should this be const Function& DartFunction(); ?

Done

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger_arm.cc
File runtime/vm/debugger_arm.cc (right):

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger_arm.cc#newc...
runtime/vm/debugger_arm.cc:10: 
On 2011/12/22 00:04:28, asiva wrote:
> extra blank line.

Done.

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger_ia32.cc
File runtime/vm/debugger_ia32.cc (right):

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger_ia32.cc#new...
runtime/vm/debugger_ia32.cc:16: 
On 2011/12/22 00:04:28, asiva wrote:
> extra blank line?

Done.

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger_ia32.cc#new...
runtime/vm/debugger_ia32.cc:19: 
On 2011/12/22 00:04:28, asiva wrote:
> extra blank line?

Done.

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger_ia32.cc#new...
runtime/vm/debugger_ia32.cc:27: 
On 2011/12/22 00:04:28, asiva wrote:
> Ditto.

Done.

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger_x64.cc
File runtime/vm/debugger_x64.cc (right):

http://codereview.chromium.org/9019029/diff/1/runtime/vm/debugger_x64.cc#newc...
runtime/vm/debugger_x64.cc:11: 
On 2011/12/22 00:04:28, asiva wrote:
> Too many blank lines?

Done.

Expand Messages | Collapse Messages