Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 9019018: Fix resolver for fields uses in constructors. (Closed)

Created:
9 years ago by ngeoffray
Modified:
9 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix resolver for fields uses in constructors. Also fix infinite loop when we're looking for the getter equivalent of a setter. Committed: https://code.google.com/p/dart/source/detail?r=2708

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M dart/frog/leg/resolver.dart View 1 3 chunks +5 lines, -3 lines 0 comments Download
M dart/frog/tests/leg/src/ResolverTest.dart View 1 1 chunk +1 line, -1 line 0 comments Download
A dart/frog/tests/leg_only/src/FieldInConstructorTest.dart View 1 chunk +21 lines, -0 lines 0 comments Download
M dart/tests/language/language-leg.status View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
9 years ago (2011-12-21 17:15:35 UTC) #1
ngeoffray
9 years ago (2011-12-21 17:27:47 UTC) #2
karlklose
9 years ago (2011-12-21 17:28:29 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698