Remove wrong test, issue 575.

Remove wrong test, issue 575.
http://code.google.com/p/dart/issues/detail?id=575


R=zundel@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=2920

[zundel, 2011-12-21 17:37:56]

http://codereview.chromium.org/9019011/diff/1/tests/language/src/Prefix14Nega...
File tests/language/src/Prefix14NegativeTest.dart (left):

http://codereview.chromium.org/9019011/diff/1/tests/language/src/Prefix14Nega...
tests/language/src/Prefix14NegativeTest.dart:11: myClass(lib12.Library13
this.fld);
I take the the problem is that lib12.Library13 is unresolved.

Removing the test isn't the only option.  Tell me what you think of this:  We
can test for a static type warning by adding:

// VMOptions=--enable_type_checks

at the top of the test and use annotations of the form:  /// 01: static type
error 

to create a multi-part test case.  See FauxverrideTest.dart for an example.

[ericzundel, 2011-12-22 21:53:10]

http://codereview.chromium.org/9019011/diff/3001/tests/language/src/Prefix21N...
File tests/language/src/Prefix21NegativeTest.dart (right):

http://codereview.chromium.org/9019011/diff/3001/tests/language/src/Prefix21N...
tests/language/src/Prefix21NegativeTest.dart:6: // VMOptions=--fatal-type-errors
--fatal-type-errors is dartc specific. 

I think we want to add --enable_type_errors for the VM and frog.  And probable
we need to  actually instantiate myClass for the VM to analyze myClass.

[scheglov, 2011-12-23 03:00:07]

On 2011/12/22 21:53:10, ericzundel wrote:
>
http://codereview.chromium.org/9019011/diff/3001/tests/language/src/Prefix21N...
> File tests/language/src/Prefix21NegativeTest.dart (right):
> 
>
http://codereview.chromium.org/9019011/diff/3001/tests/language/src/Prefix21N...
> tests/language/src/Prefix21NegativeTest.dart:6: //
VMOptions=--fatal-type-errors
> --fatal-type-errors is dartc specific. 
> 
> I think we want to add --enable_type_errors for the VM and frog.  And probable
> we need to  actually instantiate myClass for the VM to analyze myClass.

  Do you mean that we should have it tests both flags: "--fatal-type-errors" and
"--enable_type_errors"?

  Or add "--enable_type_errors" into DartC?

[zundel, 2012-01-03 15:13:13]

On 2011/12/23 03:00:07, scheglov wrote:
> On 2011/12/22 21:53:10, ericzundel wrote:
> >
>
http://codereview.chromium.org/9019011/diff/3001/tests/language/src/Prefix21N...
> > File tests/language/src/Prefix21NegativeTest.dart (right):
> > 
> >
>
http://codereview.chromium.org/9019011/diff/3001/tests/language/src/Prefix21N...
> > tests/language/src/Prefix21NegativeTest.dart:6: //
> VMOptions=--fatal-type-errors
> > --fatal-type-errors is dartc specific. 
> > 
> > I think we want to add --enable_type_errors for the VM and frog.  And
probable
> > we need to  actually instantiate myClass for the VM to analyze myClass.
> 
>   Do you mean that we should have it tests both flags: "--fatal-type-errors"
and
> "--enable_type_errors"?
> 
>   Or add "--enable_type_errors" into DartC?

What I meant was  the flag:

--enable_type_checks                   : Generate runtime type checks

Which should be implemented by both VM and dartc

[scheglov, 2012-01-03 19:05:58]

OK, now we have two sets of tests: 
1. positive, which should pass, but with warning;
2. negative, for which we turn on type checks mode, which should fail.

[zundel, 2012-01-03 19:33:11]

lgtm

[regis, 2012-02-23 19:39:33]

http://codereview.chromium.org/9019011/diff/10001/tests/language/src/Prefix22...
File tests/language/src/Prefix22NegativeTest.dart (right):

http://codereview.chromium.org/9019011/diff/10001/tests/language/src/Prefix22...
tests/language/src/Prefix22NegativeTest.dart:7: // VMOptions=--fatal-type-errors
--enable_type_errors
The VM neither supports --fatal-type-errors nor --enable_type_errors.

Since this test results in a static type warning, it should not be negative.

http://codereview.chromium.org/9019011/diff/10001/tests/language/src/Prefix23...
File tests/language/src/Prefix23NegativeTest.dart (right):

http://codereview.chromium.org/9019011/diff/10001/tests/language/src/Prefix23...
tests/language/src/Prefix23NegativeTest.dart:7: // VMOptions=--fatal-type-errors
--enable_type_errors
The VM neither supports --fatal-type-errors nor --enable_type_errors.

Since this test results in a static type warning, it should not be negative.

[zundel, 2012-02-24 00:32:25]

Kasper and I kicked off a project for all tests to be converted from negative to
either positive or multi-tests, so hopefully this test will be rewritten or go
away soon.

On 2012/02/23 19:39:33, regis wrote:
>
http://codereview.chromium.org/9019011/diff/10001/tests/language/src/Prefix22...
> File tests/language/src/Prefix22NegativeTest.dart (right):
> 
>
http://codereview.chromium.org/9019011/diff/10001/tests/language/src/Prefix22...
> tests/language/src/Prefix22NegativeTest.dart:7: //
VMOptions=--fatal-type-errors
> --enable_type_errors
> The VM neither supports --fatal-type-errors nor --enable_type_errors.
> 
> Since this test results in a static type warning, it should not be negative.
> 
>
http://codereview.chromium.org/9019011/diff/10001/tests/language/src/Prefix23...
> File tests/language/src/Prefix23NegativeTest.dart (right):
> 
>
http://codereview.chromium.org/9019011/diff/10001/tests/language/src/Prefix23...
> tests/language/src/Prefix23NegativeTest.dart:7: //
VMOptions=--fatal-type-errors
> --enable_type_errors
> The VM neither supports --fatal-type-errors nor --enable_type_errors.
> 
> Since this test results in a static type warning, it should not be negative.