Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 9019001: Tweak dartdoc look to match dartlang.org a bit more. (Closed)

Created:
9 years ago by Bob Nystrom
Modified:
9 years ago
Reviewers:
Emily Fortuna, sethladd
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tweak dartdoc look to match dartlang.org a bit more. Also prepare for adding search box. Committed: https://code.google.com/p/dart/source/detail?r=2715

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -25 lines) Patch
M utils/apidoc/apidoc.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A utils/apidoc/static/header-background.jpeg View 0 chunks +-1 lines, --1 lines 0 comments Download
A + utils/apidoc/static/styles.css View 3 chunks +8 lines, -6 lines 2 comments Download
M utils/dartdoc/dartdoc View 1 chunk +1 line, -1 line 0 comments Download
M utils/dartdoc/dartdoc.dart View 7 chunks +39 lines, -10 lines 2 comments Download
A utils/dartdoc/static/body-bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A utils/dartdoc/static/content-bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A utils/dartdoc/static/dart-logo-small.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A utils/dartdoc/static/header-bg.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M utils/dartdoc/static/styles.css View 3 chunks +37 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
It doesn't look exactly like dartlang (mainly because dartlang has a *huge* header area) but ...
9 years ago (2011-12-21 01:41:07 UTC) #1
Emily Fortuna
lgtm! http://codereview.chromium.org/9019001/diff/1/utils/apidoc/static/styles.css File utils/apidoc/static/styles.css (right): http://codereview.chromium.org/9019001/diff/1/utils/apidoc/static/styles.css#newcode92 utils/apidoc/static/styles.css:92: .page { Is it possible to make the ...
9 years ago (2011-12-21 18:27:25 UTC) #2
Bob Nystrom
9 years ago (2011-12-21 18:34:20 UTC) #3
Thanks!

http://codereview.chromium.org/9019001/diff/1/utils/apidoc/static/styles.css
File utils/apidoc/static/styles.css (right):

http://codereview.chromium.org/9019001/diff/1/utils/apidoc/static/styles.css#...
utils/apidoc/static/styles.css:92: .page {
On 2011/12/21 18:27:25, Emily Fortuna wrote:
> Is it possible to make the page go all the way down the screen, like
> http://www.dartlang.org/news/index.html? Not a big deal, but might be nice.

It is, but I actually kind of like the way it looks like this. At some point,
there will likely be footer text under the main page area (stuff like copyright
and publish date) so I like seeing some background down there.

http://codereview.chromium.org/9019001/diff/1/utils/dartdoc/dartdoc.dart
File utils/dartdoc/dartdoc.dart (right):

http://codereview.chromium.org/9019001/diff/1/utils/dartdoc/dartdoc.dart#newc...
utils/dartdoc/dartdoc.dart:73: String mainTitle = 'Dart Documentation';
On 2011/12/21 18:27:25, Emily Fortuna wrote:
> nit: Can we have a dart favicon like dartlang.org?

I tried to get that working for a little while but ran into some problems. I'll
see if I can get it going, but in a separate CL.

Powered by Google App Engine
This is Rietveld 408576698