Issue 9017015: Dartc was not raising an error if an interface declared constructors without a default clause

Issue 9017015: Dartc was not raising an error if an interface declared constructors without a default clause (Closed)

Created:
9 years ago by zundel

Modified:
9 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Dartc was not raising an error if an interface declared constructors without a default clause BUG=928 TEST= Committed: https://code.google.com/p/dart/source/detail?r=2716

Patch Set 1 : Updated the stub-generator tests to get rid of errors #

Total comments: 2

Patch Set 2 : Moved check. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -41 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/isolate/src/TestFramework.dart	View		2 chunks	+3 lines, -4 lines	0 comments	Download
A	tests/language/src/DefaultFactory1NegativeTest.dart	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
M	tests/stub-generator/src/MintMakerFullyIsolatedTest.dart	View		3 chunks	+10 lines, -10 lines	0 comments	Download
M	tests/stub-generator/src/MintMakerFullyIsolatedTest-generatedTest.dart	View		3 chunks	+10 lines, -10 lines	0 comments	Download
M	tests/stub-generator/src/MintMakerPromiseWithStubsTest.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	tests/stub-generator/src/MintMakerPromiseWithStubsTest-generatedTest.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM http://codereview.chromium.org/9017015/diff/5009/tests/language/src/DefaultFactory1NegativeTest.dart File tests/language/src/DefaultFactory1NegativeTest.dart (right): http://codereview.chromium.org/9017015/diff/5009/tests/language/src/DefaultFactory1NegativeTest.dart#newcode9 tests/language/src/DefaultFactory1NegativeTest.dart:9: } // Compile time error here Here or ...

9 years ago (2011-12-21 18:33:07 UTC) #2

zundel

9 years ago (2011-12-21 19:10:42 UTC) #3

http://codereview.chromium.org/9017015/diff/5009/tests/language/src/DefaultFa...
File tests/language/src/DefaultFactory1NegativeTest.dart (right):

http://codereview.chromium.org/9017015/diff/5009/tests/language/src/DefaultFa...
tests/language/src/DefaultFactory1NegativeTest.dart:9: } // Compile time error
here
On 2011/12/21 18:33:08, scheglov wrote:
> Here or on the line with IA() constructor declaration?

Done.

Expand Messages | Collapse Messages