Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 9016007: Update the isolate interrupt test (Closed)

Created:
9 years ago by Søren Gjesse
Modified:
9 years ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update the isolate interrupt test * Space out the interrupts by short sleeps * Use a constant instead of the magic number 3 for the number of interrups R=iposva@google.com BUG=dart:906 TEST=VM test IsolateInterrupt Committed: https://code.google.com/p/dart/source/detail?r=2740

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments from iposva@ #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M runtime/vm/dart_api_impl_test.cc View 1 6 chunks +11 lines, -7 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
9 years ago (2011-12-21 08:49:54 UTC) #1
Ivan Posva
LGTM with comment. -Ivan http://codereview.chromium.org/9016007/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): http://codereview.chromium.org/9016007/diff/1/runtime/vm/dart_api_impl_test.cc#newcode3104 runtime/vm/dart_api_impl_test.cc:3104: OS::Sleep(i + 1); If you ...
9 years ago (2011-12-21 17:27:14 UTC) #2
Søren Gjesse
http://codereview.chromium.org/9016007/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): http://codereview.chromium.org/9016007/diff/1/runtime/vm/dart_api_impl_test.cc#newcode3104 runtime/vm/dart_api_impl_test.cc:3104: OS::Sleep(i + 1); On 2011/12/21 17:27:14, Ivan Posva wrote: ...
9 years ago (2011-12-22 08:21:26 UTC) #3
Ivan Posva
http://codereview.chromium.org/9016007/diff/2001/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): http://codereview.chromium.org/9016007/diff/2001/runtime/vm/dart_api_impl_test.cc#newcode3104 runtime/vm/dart_api_impl_test.cc:3104: // Space out the interrupts a bit. Comment could ...
9 years ago (2011-12-22 08:23:10 UTC) #4
Søren Gjesse
9 years ago (2011-12-22 15:33:45 UTC) #5
http://codereview.chromium.org/9016007/diff/2001/runtime/vm/dart_api_impl_tes...
File runtime/vm/dart_api_impl_test.cc (right):

http://codereview.chromium.org/9016007/diff/2001/runtime/vm/dart_api_impl_tes...
runtime/vm/dart_api_impl_test.cc:3104: // Space out the interrupts a bit.
On 2011/12/22 08:23:10, Ivan Posva wrote:
> Comment could have moved with the corresponding code...

Done, http://codereview.chromium.org/9025014/.

Powered by Google App Engine
This is Rietveld 408576698