Add dartc junit tests to test.dart.

Add dartc junit tests to test.dart.


BUG=
TEST=tools/test.dart --component=dartc dartc/junit_tests

Committed: https://code.google.com/p/dart/source/detail?r=2885

[Bill Hesse, 2011-12-29 18:32:24]

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_runner....
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:131: print('exit code: $exitCode');
Remove this line.

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:774: return ['-check-only',
'-fatal-type-errors', '-Werror', '-out',
revert this stray edit.

[ngeoffray, 2011-12-30 10:20:00]

From what I know, LGTM

http://codereview.chromium.org/9015005/diff/1/compiler/tests/dartc/dartc.status
File compiler/tests/dartc/dartc.status (right):

http://codereview.chromium.org/9015005/diff/1/compiler/tests/dartc/dartc.stat...
compiler/tests/dartc/dartc.status:8: # This file is not used when creating the
test dartc/junit_tests.
So is that file used at all? Could you add a comment on what uses this file?

http://codereview.chromium.org/9015005/diff/1/tools/test.dart
File tools/test.dart (right):

http://codereview.chromium.org/9015005/diff/1/tools/test.dart#newcode86
tools/test.dart:86: if (conf['component'] == 'dartc' &&
selectors.containsKey('dartc')) {
This is the same condition than line 83.

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:897: for (String jar in
['args4j/2.0.12/args4j-2.0.12.jar',
Why doing a for loop instead of just adding them to the list literal?

[Bill Hesse, 2011-12-30 16:04:33]

http://codereview.chromium.org/9015005/diff/1/compiler/tests/dartc/dartc.status
File compiler/tests/dartc/dartc.status (right):

http://codereview.chromium.org/9015005/diff/1/compiler/tests/dartc/dartc.stat...
compiler/tests/dartc/dartc.status:8: # This file is not used when creating the
test dartc/junit_tests.
On 2011/12/30 10:20:06, ngeoffray wrote:
> So is that file used at all? Could you add a comment on what uses this file?

Only the component exclusions are used, and them only by the python script. 
Make comment more complete.

http://codereview.chromium.org/9015005/diff/1/tools/test.dart
File tools/test.dart (right):

http://codereview.chromium.org/9015005/diff/1/tools/test.dart#newcode86
tools/test.dart:86: if (conf['component'] == 'dartc' &&
selectors.containsKey('dartc')) {
On 2011/12/30 10:20:06, ngeoffray wrote:
> This is the same condition than line 83.

Yes, but we want to keep all of the test suites in separate, self-contained
blocks of code.

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_runner....
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:131: print('exit code: $exitCode');
On 2011/12/29 18:32:24, Bill Hesse wrote:
> Remove this line.

Done.

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_suite.dart
File tools/testing/dart/test_suite.dart (right):

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:774: return ['-check-only',
'-fatal-type-errors', '-Werror', '-out',
On 2011/12/29 18:32:24, Bill Hesse wrote:
> revert this stray edit.

Line would be too long without it.

http://codereview.chromium.org/9015005/diff/1/tools/testing/dart/test_suite.d...
tools/testing/dart/test_suite.dart:897: for (String jar in
['args4j/2.0.12/args4j-2.0.12.jar',
On 2011/12/30 10:20:06, ngeoffray wrote:
> Why doing a for loop instead of just adding them to the list literal?

These are all third-party libraries, so we want to keep them all together, and
list them just with their library names.

But I have rewritten without the for loop.