Fix dartc bounds checking for invoking interface constructors/factory methods

Fix dartc bounds checking for invoking interface constructors/factory methods

http://code.google.com/p/dart/issues/detail?id=943

Committed: https://code.google.com/p/dart/source/detail?r=2957

[scheglov, 2012-01-04 18:01:13]

http://codereview.chromium.org/9014029/diff/5009/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

http://codereview.chromium.org/9014029/diff/5009/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1036: // in the
default class than defined in the interface.
I don't see in tests "tighter" case, only case when bounds are the same. Also
not clear what if default class bounds are _less_ tight. Error? Already tested?

[zundel, 2012-01-04 18:18:19]

http://codereview.chromium.org/9014029/diff/5009/compiler/java/com/google/dar...
File compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java (right):

http://codereview.chromium.org/9014029/diff/5009/compiler/java/com/google/dar...
compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java:1036: // in the
default class than defined in the interface.
On 2012/01/04 18:01:15, scheglov wrote:
> I don't see in tests "tighter" case, only case when bounds are the same. Also
> not clear what if default class bounds are _less_ tight. Error? Already
tested?

The spec doesn't actually state tighter bounds, but my understanding is that
this is the intention.

http://codereview.chromium.org/9014029/diff/5009/tests/language/src/DefaultFa...
File tests/language/src/DefaultFactory2Test.dart (right):

http://codereview.chromium.org/9014029/diff/5009/tests/language/src/DefaultFa...
tests/language/src/DefaultFactory2Test.dart:9: interface IA<T> default A<T
extends Foo> { IA(); }
Here is the tighter bound.

When you invoke IA<T>, it is really invoking A<T extends Foo>
The constructor must be parameterized with a bound for T that extends Foo.  That
is why there is a static type error at line 16.

[scheglov, 2012-01-04 18:22:19]

lgtm

[codefu, 2012-01-04 18:22:55]

lgtm