Issue 9007027: Add (debug) printing when IC is used in optimized code (must eliminate it).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9007027: Add (debug) printing when IC is used in optimized code (must eliminate it). (Closed)

Created:
9 years ago by srdjan

Modified:
9 years ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add (debug) printing when IC is used in optimized code (must eliminate it). Do Smi binary op only on two Smi-s. Increase deopt counter limit to 5., which still may be too low. Deopt counter is here mainly to prevent drastic performance degradations because of bugs or missing implementations. Committed: https://code.google.com/p/dart/source/detail?r=2673

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -58 lines)			Patch
M	runtime/vm/code_generator_ia32.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/opt_code_generator_ia32.cc	View	1	6 chunks	+47 lines, -57 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM http://codereview.chromium.org/9007027/diff/2002/runtime/vm/opt_code_generator_ia32.cc File runtime/vm/opt_code_generator_ia32.cc (right): http://codereview.chromium.org/9007027/diff/2002/runtime/vm/opt_code_generator_ia32.cc#newcode665 runtime/vm/opt_code_generator_ia32.cc:665: ASSERT(!cls0.IsNull() && !cls1.IsNull()); You could move this assertion ...

9 years ago (2011-12-20 21:50:08 UTC) #2

srdjan

9 years ago (2011-12-20 21:55:05 UTC) #3

http://codereview.chromium.org/9007027/diff/2002/runtime/vm/opt_code_generato...
File runtime/vm/opt_code_generator_ia32.cc (right):

http://codereview.chromium.org/9007027/diff/2002/runtime/vm/opt_code_generato...
runtime/vm/opt_code_generator_ia32.cc:665: ASSERT(!cls0.IsNull() &&
!cls1.IsNull());
On 2011/12/20 21:50:08, hausner wrote:
> You could move this assertion after line 670 to make debug builds a wee bit
> faster. 

Yes, but I want to catch mistakes at call site earlier (values for cls1 and
cls2), even if we return false.

Expand Messages | Collapse Messages